Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of SQLSetDescRec & SQLGetDescRec functions #23

Merged
merged 4 commits into from
Aug 11, 2024
Merged

Implementation of SQLSetDescRec & SQLGetDescRec functions #23

merged 4 commits into from
Aug 11, 2024

Conversation

Hunaid2000
Copy link
Contributor

@Hunaid2000 Hunaid2000 commented May 23, 2024

Resolves #21.

  • Completed implementation of SQLSetDescRec function.
  • Fixed SQL_DESC_PRECISION field in IPDSetField & IPDGetField functions.
  • Added support for following fields for bookmark column in ARDSetField .
    • SQL_DESC_TYPE
    • SQL_DESC_DATETIME_INTERVAL_CODE
    • SQL_DESC_OCTET_LENGTH
    • SQL_DESC_PRECISION
    • SQL_DESC_SCALE

Note:
I am now working on SQLGetDescRec implementation.

- Fixed SQL_DESC_PRECISION field in IPDSetField & IPDGetField functions
- Added support for other fields for bookmark column in ARDSetField
  - SQL_DESC_TYPE
  - SQL_DESC_DATETIME_INTERVAL_CODE
  - SQL_DESC_OCTET_LENGTH
  - SQL_DESC_PRECISION
  - SQL_DESC_SCALE
@Hunaid2000 Hunaid2000 changed the title Implemention of SQLSetDescRec & SQLGetDescRec functions Implementation of SQLSetDescRec & SQLGetDescRec functions May 24, 2024
- Handled SQL_NO_DATA case in GetField functions
- Handled 01004 SQLSTATE in GetField functions
- Added support for SQL_DESC_NAME & SQL_DESC_NULLABLE IPDGetField functions
@Hunaid2000 Hunaid2000 marked this pull request as ready for review May 29, 2024 08:22
@Hunaid2000
Copy link
Contributor Author

Implementation for both functions is completed.

Other changes:

  • Handled SQL_NO_DATA case in GetField functions
  • Handled 01004 SQLSTATE in GetField functions
  • Added support for SQL_DESC_NAME & SQL_DESC_NULLABLE in IPDGetField function

@Hunaid2000
Copy link
Contributor Author

@davecramer any update on this?

@davecramer
Copy link
Contributor

@Hunaid2000 Ideally we would add tests for these new functions ?
Any chance you can add them ?

@Hunaid2000
Copy link
Contributor Author

I will try to add them.

- Updated PGAPI_GetFunctions function to get new functions
- Updated psqlodbc.def file for new functions on Windows
- Fixed HY007 error handling
@Hunaid2000
Copy link
Contributor Author

@davecramer I have added regression test.

@davecramer davecramer merged commit 334247d into postgresql-interfaces:main Aug 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plan to implement SQLSetDescRec & SQLGetDescRec functions
2 participants