Add support for execution of tests on Linux environment #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@poulfoged Please review the PR. |
poulfoged
reviewed
Jun 23, 2019
| public interface IConfig | ||
| { | ||
| IConfig Port(int portNumber); | ||
| IConfig LogTo(Action<string> logFunction); |
There was a problem hiding this comment.
Why remove the ability to log to anything?
There was a problem hiding this comment.
This functionality is still there in IConfig, now as method.
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>net451;net46;netstandard2.0</TargetFrameworks> | |||
There was a problem hiding this comment.
We should be able to keep the old frameworks right?
There was a problem hiding this comment.
It is difficult, as some of the dependencies are not available in old framework. Only only option is to add conditional compilation for different flavors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.