Login required fields #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjuju
requested changes
Nov 13, 2024
pgiraud
force-pushed
the
login_required_fields
branch
from
0ee5dd6 to
b30feed
Compare
rjuju
approved these changes
Nov 13, 2024
Along the way, we use v-select for server chooser instead of v-combobox to prevent user from providing a non-existing value (free typing). And the server is auto selected if there's only one.
pgiraud
force-pushed
the
login_required_fields
branch
from
ebd8cb8 to
4ede305
Compare
Done! |
|
thanks! |
rjuju
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.