Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce relax Ok miss multiplier #32434

Merged
merged 1 commit into from
Apr 9, 2025

Conversation

stanriders
Copy link
Member

@stanriders stanriders commented Mar 17, 2025

This changes Ok multiplier so that it is never a full miss and is less harsh overall. It's mostly a blind adjustment towards better values and not a set in stone solution

image
https://www.desmos.com/calculator/bhnwk3zupt

Since it's impossible to test using normal tools I've also made a separate version that's using rx vault as the api source, you can use that to see what this change actually does: https://github.com/stanriders/osu-tools/tree/rxvault

image

@stanriders stanriders requested a review from a team March 17, 2025 22:48
@stanriders stanriders moved this to Pending Review in Difficulty calculation changes Mar 17, 2025
@stanriders stanriders changed the title Reduce relax Ok multiplier Reduce relax Ok miss multiplier Mar 17, 2025
@Ratchet0203
Copy link

As someone who plays mostly 5+ min maps with RX, I feel like the 100/50 counts used for the pp multiplier should be scaled with object count, so it would keep long maps from having a disadvantage for non-SS relax plays. At least until miss penalty itself is improved in this manner.

tsunyoku
tsunyoku previously approved these changes Apr 9, 2025
@tsunyoku tsunyoku moved this from Pending Review to Pending Merge in Difficulty calculation changes Apr 9, 2025
@tsunyoku tsunyoku enabled auto-merge (squash) April 9, 2025 12:21
@tsunyoku tsunyoku disabled auto-merge April 9, 2025 12:21
@tsunyoku tsunyoku changed the base branch from master to pp-dev April 9, 2025 12:21
@tsunyoku tsunyoku dismissed their stale review April 9, 2025 12:21

The base branch was changed.

@tsunyoku tsunyoku force-pushed the reduce-rx-ok-multiplier branch from a57c3e0 to aef72f7 Compare April 9, 2025 12:27
@tsunyoku tsunyoku enabled auto-merge (squash) April 9, 2025 12:28
@tsunyoku tsunyoku merged commit 30f9716 into ppy:pp-dev Apr 9, 2025
7 of 8 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge to Pending Deploy in Difficulty calculation changes Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Pending Deploy
Development

Successfully merging this pull request may close these issues.

3 participants