Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use hidden if OnlyFadeApproachCircles is not enabled #32603

Open
wants to merge 2 commits into
base: pp-dev
Choose a base branch
from

Conversation

Finadoggie
Copy link
Contributor

@Finadoggie Finadoggie commented Mar 27, 2025

That option removes the main sources of difficulty for hd (pp wise), so it shouldn't give pp.

Specifically targets these twitter clips where someone gains absurd amounts of pp because they're playing low ar with "hd" https://x.com/zTarax/status/1903173463969546708

I don't think it's unreasonable to say that low ar hd isn't nearly as hard when you can see the circles.

@Finadoggie
Copy link
Contributor Author

tbh this could probably be merged straight into master since it affects zero ranked scores

@bdach
Copy link
Collaborator

bdach commented Mar 27, 2025

I'm gonna be real, the three thumbs down emojis within 15 minutes of open have me doubting any fast merges "straight into master".

@bdach bdach requested a review from a team March 27, 2025 06:01
@Finadoggie
Copy link
Contributor Author

Finadoggie commented Mar 27, 2025

I never said it needed to be fast, I just meant it could skip the pp dev branch since it wouldn't need to wait for a deploy

@smoogipoo
Copy link
Contributor

pp-dev is the correct target for this change.

@Givikap120
Copy link
Contributor

I would personally prefer reducing bonus instead of removing it completely because HD still adds noticeable amount of difficulty even with OnlyFadeApproachCircles option

@stanriders
Copy link
Member

I don't think this kind of a kneejerk fix is warranted in any way. Completely removing the bonus for a hidden setting is way too uninspired of a fix and I would rather see something like this instead.

There is no reason for quickly slapping a blanket nerf and especially merge it into master when the mod setting is not ranked and the only thing it affects are people on twitter baiting with a pp counter.

untested because git is a nightmare
@Finadoggie
Copy link
Contributor Author

ignore commit comment, code is tested and works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants