Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for ScoreV2 in Standard Difficulty Calculations #32634

Open
wants to merge 1 commit into
base: pp-dev
Choose a base branch
from

Conversation

Finadoggie
Copy link
Contributor

@Finadoggie Finadoggie commented Mar 30, 2025

This does not affect ranked play whatsoever. However, if sorting leaderboards by pp is implemented, this will affect local leaderboards with imported sv2 scores. Also (probably) impacts any community-made tournament pp calculators.

tl;dr this change doesn't have much reach but the performance impact is one if statement so I see no reason not to have it

@Finadoggie
Copy link
Contributor Author

meant to target pp-dev, not master

@Finadoggie Finadoggie changed the base branch from master to pp-dev March 30, 2025 06:09
@Finadoggie Finadoggie changed the title Add Support for ScoreV2 in Osu Difficulty Calculations Add Support for ScoreV2 in Standard Difficulty Calculations Mar 30, 2025
@mcendu
Copy link
Contributor

mcendu commented Apr 2, 2025

Stable ScoreV2 scores probably shouldn't carry the Classic mod on import, since ScoreV2 is pretty close to Lazer's scoring and behavior.

@BunnyTub
Copy link

BunnyTub commented Apr 2, 2025

The Classic mod should still be carried in my opinion, as slider head accuracy and slider functionality differ. ScoreV2 on stable attempts to scale all hit object scoring values to a hard limit of 1 million at 1.00 Score Multiplier (excluding bonus spinner values in osu!, dendens in osu!taiko, and collected bananas in osu!catch). Taken that part from the wiki. It means that while the scoring methods are similar, they aren't the same, even with the score cap, if that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants