Added ACE's font size and theme variables #1276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the font size and theme every single time I edit a file is annoying. This PR address issue #1171.
That issue was about adding global variables to change the ACE editor theme and font size in
config.php, the same way it happens in other configurations. PR #1200 only partially solved the issue of the font size not changing when editingtinyfilemanager.phpdirectly.With this PR I added global constants defined right after the inclusion of the config.php file. Their values are conditional, and depend on whether or not there are variables defined in config.php. The code is super short, and easy to understand, it only changes 4 lines.
If you want to set custom values, just include these lines in config.php:
Default values are
12andtextmate.I tried using normal global variables instead of using constants, but it didn't work. For some reason when I add
<?php echo $variable; ?>to set font size and theme it doesn't work, but when I use constant it works:<?php echo CONSTANT; ?>.I'm open to suggestions, it's always good to learn.