Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Round to four decimal places anywhere real numbers are used #10

Closed
wants to merge 6 commits into from
Closed

Round to four decimal places anywhere real numbers are used #10

wants to merge 6 commits into from

Conversation

practicingruby
Copy link
Member

No description provided.

@practicingruby practicingruby mentioned this pull request Oct 5, 2014
Closed
@practicingruby practicingruby changed the title Round to 4 decimal places in dash_setting Round to four decimal places anywhere real numbers are used Oct 6, 2014
@practicingruby practicingruby mentioned this pull request Oct 6, 2014
Closed
@practicingruby
Copy link
Member Author

This is a little confusing because some of the tests for this code still live in Prawn and need to be moved over here. I don't want to do that right now, but it'll need to happen in the future.

What I've done for the moment is added/modified tests here when no test existed in either place, or when the test was already in PDF::Core. Everything else I added or changed in Prawn's test.

The only reason I didn't move the tests is that I'm still trying to figure out the right dividing lines between Prawn and PDF::Core ,and I want to give that some more thought. A good example of something that doesn't have a quick and easy answer is #12

With these changes, I'd say we're pretty much ready to merge, pending some kicking of the tires downstream in Prawn.

@practicingruby
Copy link
Member Author

Squashed and merged in efd6593

@pointlessone pointlessone deleted the decimal-rounding branch December 30, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@practicingruby