.NET: Move list creation into write lock

praydog · Sep 17, 2024 · 8136d48 · 8136d48
1 parent fe3b0d5
commit 8136d48
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/csharp-api/REFrameworkNET/TypeDefinition.cpp b/csharp-api/REFrameworkNET/TypeDefinition.cpp
@@ -302,15 +302,16 @@ namespace REFrameworkNET {
 
     System::Collections::Generic::List<REFrameworkNET::ManagedObject^>^ TypeDefinition::GetRuntimeMethods() {
         if (m_runtimeMethods == nullptr) {
-            m_runtimeMethods = gcnew System::Collections::Generic::List<ManagedObject^>();
             auto runtimeType = GetRuntimeType();
 
             m_lock->EnterWriteLock();
 
+            m_runtimeMethods = gcnew System::Collections::Generic::List<ManagedObject^>();
+
             try {
                 if (runtimeType != nullptr) {
                     auto methods = (REFrameworkNET::ManagedObject^)runtimeType->Call("GetMethods(System.Reflection.BindingFlags)", System::Reflection::BindingFlags::Public | System::Reflection::BindingFlags::NonPublic | System::Reflection::BindingFlags::Instance | System::Reflection::BindingFlags::Static);
-                    
+
                     if (methods != nullptr) {
                         for each (REFrameworkNET::ManagedObject^ method in methods) {
                             if (method == nullptr) {