Brainx Bid Adapter : initial release #12413

Hugh0222 · 2024-11-05T07:36:19Z

Type of change

Description of change

Other information

patmmccann · 2024-11-05T19:44:23Z

modules/brainxBidAdapter.js

+    data.user = {
+      buyeruid: generateUUID()
+    }
+    data.device.ip = navigator.ip || '202.100.48.46';


what is this fallback lol :)

patmmccann · 2024-11-05T19:44:40Z

modules/brainxBidAdapter.js

+    // console.log('bidRequests-==========', bidRequests);
+    // console.log('bidderRequest-==========', bidderRequest);
+    data.user = {
+      buyeruid: generateUUID()


this is odd, it will change every request

Hugh0222 · 2024-11-06T02:12:33Z

Our current processing is temporary, and the main purpose is to determine what problems there are during the review process. Regarding the fixed writing method, we are already adjusting it~

…

On Wed, Nov 6, 2024 at 3:45 AM Patrick McCann ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In modules/brainxBidAdapter.js <#12413 (comment)>: > + } + + if (!(bid.params.pubId)) { + logWarn('Invalid bid request - missing required field pubId'); + return false; + } + return true; + }, + buildRequests(bidRequests, bidderRequest) { + const data = converter.toORTB({ bidRequests, bidderRequest }) + const device = config.getConfig('device') || {}; + // console.log('data-==========', data); + // console.log('bidRequests-==========', bidRequests); + // console.log('bidderRequest-==========', bidderRequest); + data.user = { + buyeruid: generateUUID() this is odd, it will change every request — Reply to this email directly, view it on GitHub <#12413 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BMSAGRP6HWMJWANEFHZS73LZ7EN33AVCNFSM6AAAAABRF4SNH6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMJWGU2DOMJUGE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

bretg · 2024-11-07T17:38:03Z

modules/brainxBidAdapter.js

+    }
+    return {
+      method: METHOD,
+      url: `${String(deepAccess(bidRequests[0], 'params.endpoint'))}?token=${String(deepAccess(bidRequests[0], 'params.pubId'))}`,


endpoint cannot be a required parameter. It is incredibly awkward for publishers to have to enter a hostname on thousands of adunits when this is a global config.

It may be an optional parameter, but a default is required.

You may also ask the publisher to

pbjs.setConfig({ "brainx": { "endpoint": "URL" } });

At least this is not then replicated thousands of times for each adunit.

OK, thank you for your reply. We will continue to make adjustments

Hello, bretg, we have made adjustments to the above issues. Please review it again.

bretg

my review only covers that endpoint is no longer a required param

bretg · 2024-11-13T13:22:39Z

docs PR prebid/prebid.github.io#5689

Hugh0222 · 2024-11-25T02:32:47Z

我的评论仅涵盖端点不再是必需参数

Hi bretg, I was wondering when the next merge code will be released?

bretg · 2024-11-25T14:12:40Z

@ChrisHuie - please assign this to someone for proper review.

@Hugh0222 - sorry, we do not have a committed service-level agreement on how long it takes a pull request to get through review. It depends on the complexity and quality of the code as well as the availability of qualified reviewers.

ChrisHuie · 2024-12-09T17:34:32Z

integrationExamples/gpt/hello_world.html

                params: {
-                    placementId: 13144370
+                    pubId: 'F7B53DBC-85C1-4685-9A06-9CF4B6261FA3'
                }


please remove changes to this file in pr

Already restored

ChrisHuie · 2024-12-09T17:34:48Z

integrationExamples/gpt/x-domain/creative.html

@@ -2,7 +2,7 @@
 // creative will be rendered, e.g. GAM delivering a SafeFrame

 // this code is autogenerated, also available in 'build/creative/creative.js'
-<script>!function(){"use strict";const e="Prebid Event",n=(()=>{const e={frameBorder:0,scrolling:"no",marginHeight:0,marginWidth:0,topMargin:0,leftMargin:0,allowTransparency:"true"};return(n,t)=>{const r=n.createElement("iframe");return Object.entries(Object.assign({},t,e)).forEach((([e,n])=>r.setAttribute(e,n))),r}})();function t(e){return!!e.frames.__pb_locator__}window.pbRender=function(r){let o=r.parent;try{for(;o!==r.top&&!t(o);)o=o.parent;t(o)||(o=r.parent)}catch(e){}return function({adId:t,pubUrl:s,clickUrl:i}){const c=new URL(s,window.location).origin;function a(e,n,r){const s=new MessageChannel;s.port1.onmessage=u(r),o.postMessage(JSON.stringify(Object.assign({message:e,adId:t},n)),c,[s.port2])}function d(n){a(e,{event:"adRenderFailed",info:{reason:n?.reason||"exception",message:n?.message}}),n?.stack&&console.error(n)}function u(e){return function(){try{return e.apply(this,arguments)}catch(e){d(e)}}}a("Prebid Request",{options:{clickUrl:i}},(function(o){let s;try{s=JSON.parse(o.data)}catch(e){return}if("Prebid Response"===s.message&&s.adId===t){const t=n(r.document,{width:0,height:0,style:"display: none",srcdoc:`<script>${s.renderer}<\/script>`});t.onload=u((function(){const o=t.contentWindow;o.Promise.resolve(o.render(s,{sendMessage:a,mkFrame:n},r)).then((()=>a(e,{event:"adRenderSucceeded"})),d)})),r.document.body.appendChild(t)}}))}}(window)}();</script>
+<script>(()=>{"use strict";const e="Prebid Event",n=(()=>{const e={frameBorder:0,scrolling:"no",marginHeight:0,marginWidth:0,topMargin:0,leftMargin:0,allowTransparency:"true"};return(n,t)=>{const r=n.createElement("iframe");return Object.entries(Object.assign({},t,e)).forEach((([e,n])=>r.setAttribute(e,n))),r}})();function t(e){return!!e.frames.__pb_locator__}window.pbRender=function(r){let o=r.parent;try{for(;o!==r.top&&!t(o);)o=o.parent;t(o)||(o=r.parent)}catch(e){}return function({adId:t,pubUrl:s,clickUrl:i}){const a=new URL(s,window.location).origin;function c(e,n,r){const s=new MessageChannel;s.port1.onmessage=l(r),o.postMessage(JSON.stringify(Object.assign({message:e,adId:t},n)),a,[s.port2])}function d(n){c(e,{event:"adRenderFailed",info:{reason:n?.reason||"exception",message:n?.message}}),n?.stack&&console.error(n)}function l(e){return function(){try{return e.apply(this,arguments)}catch(e){d(e)}}}c("Prebid Request",{options:{clickUrl:i}},(function(o){let s;try{s=JSON.parse(o.data)}catch(e){return}if("Prebid Response"===s.message&&s.adId===t){const t=n(r.document,{width:0,height:0,style:"display: none",srcdoc:`<script>${s.renderer}<\/script>`});t.onload=l((function(){const o=t.contentWindow;o.Promise.resolve(o.render(s,{sendMessage:c,mkFrame:n},r)).then((()=>c(e,{event:"adRenderSucceeded"})),d)})),r.document.body.appendChild(t)}}))}}(window)})();</script>

 <script>
    pbRender({


please remove changes to this file in the pr

Already restored

hugh.qu added 4 commits October 31, 2024 16:25

add brainx adpater

c34d66c

fix adpater md

c52b2e7

delete console

5426a3b

fix repeat

59e0a80

patmmccann changed the title ~~First add adpater~~ Brainx adapter: initial commit Nov 5, 2024

patmmccann reviewed Nov 5, 2024

View reviewed changes

patmmccann added the feature label Nov 5, 2024

Modify fixed parameters

bb0a25b

bretg requested changes Nov 7, 2024

View reviewed changes

hugh.qu added 2 commits November 8, 2024 11:26

Modify endpoint to be optional

bf48d1f

fix email

5714faa

bretg approved these changes Nov 12, 2024

View reviewed changes

update endpoint url

cc503eb

Merge branch 'prebid:master' into master

bbd6677

ChrisHuie self-requested a review December 9, 2024 13:33

ChrisHuie self-assigned this Dec 9, 2024

ChrisHuie reviewed Dec 9, 2024

View reviewed changes

hugh.qu and others added 5 commits December 11, 2024 10:51

remove hello_html & x-domain history changes

4273be8

Merge branch 'master' of https://github.com/Hugh0222/Prebid.js

d949c07

fix size

f57629a

remove empty line

8af84c4

Update brainxBidAdapter.md

4d530d1

ChrisHuie approved these changes Dec 17, 2024

View reviewed changes

ChrisHuie changed the title ~~Brainx adapter: initial commit~~ Brainx Bid Adapter : initial commit Dec 17, 2024

ChrisHuie changed the title ~~Brainx Bid Adapter : initial commit~~ Brainx Bid Adapter : initial release Dec 17, 2024

ChrisHuie merged commit 8686d9e into prebid:master Dec 17, 2024
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Brainx Bid Adapter : initial release #12413

Brainx Bid Adapter : initial release #12413

Hugh0222 commented Nov 5, 2024 •

edited

Loading

patmmccann Nov 5, 2024

patmmccann Nov 5, 2024

Hugh0222 commented Nov 6, 2024 via email

bretg Nov 7, 2024

Hugh0222 Nov 8, 2024

Hugh0222 Nov 12, 2024

bretg left a comment

bretg commented Nov 13, 2024

Hugh0222 commented Nov 25, 2024

bretg commented Nov 25, 2024

ChrisHuie Dec 9, 2024

Hugh0222 Dec 11, 2024

ChrisHuie Dec 9, 2024

Hugh0222 Dec 11, 2024

Brainx Bid Adapter : initial release #12413

Brainx Bid Adapter : initial release #12413

Conversation

Hugh0222 commented Nov 5, 2024 • edited Loading

Type of change

Description of change

Other information

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hugh0222 commented Nov 6, 2024 via email

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bretg left a comment

Choose a reason for hiding this comment

bretg commented Nov 13, 2024

Hugh0222 commented Nov 25, 2024

bretg commented Nov 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Hugh0222 commented Nov 5, 2024 •

edited

Loading