Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarthub: renaming Smarthub to Attekmi #12432

Merged
merged 13 commits into from
Nov 14, 2024
+15 −13
Merged

Smarthub: renaming Smarthub to Attekmi #12432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ae03c98
update adapter SmartHub: add aliases
SmartHubSolutions May 23, 2024
6f1cdfe
Merge branch 'prebid:master' into master
SmartHubSolutions May 30, 2024
e417845
Merge branch 'prebid:master' into master
SmartHubSolutions Jun 18, 2024
4769dab
Merge branch 'prebid:master' into master
SmartHubSolutions Jun 27, 2024
3fb4eed
Merge branch 'prebid:master' into master
SmartHubSolutions Jun 27, 2024
82eaa28
Merge branch 'prebid:master' into master
SmartHubSolutions Jul 7, 2024
6d8a1b7
Merge branch 'prebid:master' into master
SmartHubSolutions Jul 9, 2024
fe76432
Merge branch 'prebid:master' into master
SmartHubSolutions Jul 12, 2024
86269a2
Merge branch 'prebid:master' into master
SmartHubSolutions Jul 12, 2024
5f2269f
Merge branch 'prebid:master' into master
SmartHubSolutions Nov 10, 2024
8cd2614
Smarthub: renaming Smarthub to Attekmi
Nov 10, 2024
086c66c
fix tests
Nov 10, 2024
32c1ea1
add attekmi alias
Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions modules/smarthubBidAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,21 @@ import {

const BIDDER_CODE = 'smarthub';
const ALIASES = [
{code: 'attekmi', skipPbsAliasing: true},
{code: 'markapp', skipPbsAliasing: true},
{code: 'jdpmedia', skipPbsAliasing: true},
{code: 'tredio', skipPbsAliasing: true},
{code: 'felixads', skipPbsAliasing: true},
{code: 'vimayx', skipPbsAliasing: true},
];
const BASE_URLS = {
smarthub: 'https://prebid.smart-hub.io/pbjs',
markapp: 'https://markapp-prebid.smart-hub.io/pbjs',
jdpmedia: 'https://jdpmedia-prebid.smart-hub.io/pbjs',
tredio: 'https://tredio-prebid.smart-hub.io/pbjs',
felixads: 'https://felixads-prebid.smart-hub.io/pbjs',
vimayx: 'https://vimayx-prebid.smart-hub.io/pbjs',
attekmi: 'https://prebid.attekmi.com/pbjs',
smarthub: 'https://prebid.attekmi.com/pbjs',
markapp: 'https://markapp-prebid.attekmi.com/pbjs',
jdpmedia: 'https://jdpmedia-prebid.attekmi.com/pbjs',
tredio: 'https://tredio-prebid.attekmi.com/pbjs',
felixads: 'https://felixads-prebid.attekmi.com/pbjs',
vimayx: 'https://vimayx-prebid.attekmi.com/pbjs',
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you add Attekmi as another alias and add docs for it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are currently rebranding the entire company, and changed Smarthub to Attekmi. We also leave simultaneous support for old *-prebid.smart-hub.io endpoints and new *-prebid.attekmi.con endpoints for current connections.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you add support for that alias?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you meant to add an alias for future changes, then I understand you and I added the Attekmi alias.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!


const _getUrl = (partnerName) => {
Expand Down
10 changes: 5 additions & 5 deletions modules/smarthubBidAdapter.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
# Overview

```
Module Name: SmartHub Bidder Adapter
Module Type: SmartHub Bidder Adapter
Maintainer: [email protected]
Module Name: Attekmi Bidder Adapter
Module Type: Attekmi Bidder Adapter
Maintainer: [email protected]
```

# Description

Connects to SmartHub exchange for bids.
Connects to Attekmi exchange for bids.

SmartHub bid adapter supports Banner, Video (instream and outstream) and Native.
Attekmi bid adapter supports Banner, Video (instream and outstream) and Native.

# Test Parameters
```
Expand Down
4 changes: 2 additions & 2 deletions test/spec/modules/smarthubBidAdapter_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,11 +139,11 @@ describe('SmartHubBidAdapter', function () {
});

it('Returns valid URL', function () {
expect(serverRequest.url).to.equal(`https://prebid.smart-hub.io/pbjs?partnerName=testname`);
expect(serverRequest.url).to.equal(`https://prebid.attekmi.com/pbjs?partnerName=testname`);
});

it('Returns valid URL if alias', function () {
expect(requestAlias.url).to.equal(`https://${bidderAlias}-prebid.smart-hub.io/pbjs`);
expect(requestAlias.url).to.equal(`https://${bidderAlias}-prebid.attekmi.com/pbjs`);
});

it('Returns general data valid', function () {
Expand Down