-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Michao Bid Adapter: Initial release #12507
Open
hogekai
wants to merge
21
commits into
prebid:master
Choose a base branch
from
hogekai:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…g for parameter validation
Hi, regarding the proposed library, Muuki has provided support. |
patmmccann
reviewed
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
(Turn on debug mode)
Other information
Nice to meet you!
Thanks for the great solution.
We have developed a new adapter and noticed that the outstream video ad (in renderer) is not well maintained around it.
Prebid-outstream is not working in its current version and the examples on Prebid.org are not well maintained.
So we thought it would be useful to have a library dedicated to in-renderer integration without the need for hosting, so we developed one. (https://github.com/hogekai/in-renderer-js)
The UI has been adjusted for outstream video ads, and we plan to develop the README and other related documentation in the future.
(If you want to check how it works, you can check the test ads by using the debug mode and test parameters, as they are included in this adapter.)
If you would like, please let us know what you think and what steps you would like to take to get the in-renderer integration area in place.
(Perhaps this is not the right place to ask. If I'm wrong, please let me know where I should ask. I would appreciate it if you would consider that I am not as familiar with Prebid.js as the maintainer).