-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rediads Bid Adapter : initial release #12525
Conversation
Tread carefully! This PR adds 1 linter error (possibly disabled through directives):
|
@ChrisHuie I wanted to kindly request your review on Pull Request. If there's anything missing or any changes required to align with the project guidelines, please let me know, and I’ll be happy to address them promptly. |
@ChrisHuie I wanted to kindly follow up on my pull request. If there’s anything missing or any adjustments required to align with the project guidelines, I’d be happy to address them promptly. I truly appreciate the time and effort you dedicate to maintaining this project, and I’m grateful for your guidance. Please let me know if there’s an expected timeline for review, and I’ll make sure to accommodate accordingly. Thank you again for your support, and I look forward to your feedback. |
modules/rediadsBidAdapter.js
Outdated
} | ||
|
||
deepSetValue(data, 'ext.rediads.params', params); | ||
deepSetValue(data, 'site.content', config.getConfig('content')); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't need to import config here. This should be coming from the bid request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChrisHuie , We've addressed the review point by removing the config import. The site.content
value is now sourced directly from the bid request, ensuring it aligns with the expected design. Let us know if you need any further changes!
Type of change
Bugfix
Feature
New bidder adapter
Updated bidder adapter
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Does this change affect user-facing APIs or examples documented on http://prebid.org?
Other
Description of change
Pull request to add rediads bidder adapter into prebid.js
Note - Please add 'rediads-test-bid' to the page URL's hash to enable test bids
Other information
Related dev docs PR - prebid/prebid.github.io#5743