Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rediads Bid Adapter : initial release #12525

Merged
merged 11 commits into from
Dec 17, 2024

Conversation

rediads
Copy link
Contributor

@rediads rediads commented Nov 30, 2024

Type of change

  • Bugfix

  • Feature

  • New bidder adapter

  • Updated bidder adapter

  • Code style update (formatting, local variables)

  • Refactoring (no functional changes, no api changes)

  • Build related changes

  • CI related changes

  • Does this change affect user-facing APIs or examples documented on http://prebid.org?

  • Other

Description of change

Pull request to add rediads bidder adapter into prebid.js

  • contact email of the adapter’s maintainer : [email protected]
  • test parameters for validating bids:
{
  bidder: 'rediads',
  params: {
     account_id: '123',
     site: 'rediads.com',
     slot: '321'
  }
}

Note - Please add 'rediads-test-bid' to the page URL's hash to enable test bids

Other information

Related dev docs PR - prebid/prebid.github.io#5743

Copy link

github-actions bot commented Dec 1, 2024

Tread carefully! This PR adds 1 linter error (possibly disabled through directives):

  • modules/rediadsBidAdapter.js (+1 error)

@rediads
Copy link
Contributor Author

rediads commented Dec 5, 2024

@ChrisHuie I wanted to kindly request your review on Pull Request. If there's anything missing or any changes required to align with the project guidelines, please let me know, and I’ll be happy to address them promptly.
Thank you for your time and effort in maintaining this project. I appreciate your guidance and look forward to your feedback.

@ChrisHuie ChrisHuie self-requested a review December 6, 2024 12:19
@ChrisHuie ChrisHuie self-assigned this Dec 6, 2024
@ChrisHuie ChrisHuie changed the title Rediads bid adapter Rediads Bid Adapter : initial release Dec 6, 2024
@rediads
Copy link
Contributor Author

rediads commented Dec 16, 2024

@ChrisHuie I wanted to kindly follow up on my pull request. If there’s anything missing or any adjustments required to align with the project guidelines, I’d be happy to address them promptly.

I truly appreciate the time and effort you dedicate to maintaining this project, and I’m grateful for your guidance. Please let me know if there’s an expected timeline for review, and I’ll make sure to accommodate accordingly.

Thank you again for your support, and I look forward to your feedback.

}

deepSetValue(data, 'ext.rediads.params', params);
deepSetValue(data, 'site.content', config.getConfig('content'));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't need to import config here. This should be coming from the bid request.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisHuie , We've addressed the review point by removing the config import. The site.content value is now sourced directly from the bid request, ensuring it aligns with the expected design. Let us know if you need any further changes!

@ChrisHuie ChrisHuie merged commit b39d070 into prebid:master Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants