33across ID System: Include hashed email from storage #12529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
reviewed
Dec 12, 2024
modules/33acrossIdSystem.js
Outdated
| @@ -97,6 +98,11 @@ function calculateQueryStringParams(pid, gdprConsentData, enabledStorageTypes) { | |||
| params.tp = encodeURIComponent(tp); | |||
| } | |||
|
|
|||
| const hem = getStoredValue(STORAGE_HEM_KEY, enabledStorageTypes); | |||
There was a problem hiding this comment.
what if a publisher wanted to pass this on your config params?
There was a problem hiding this comment.
Hi @patmmccann
that's a good point, I think we could easily implement this functionality and add it to the PR... working on it.
There was a problem hiding this comment.
I've added the option to pass hashed email via configuration param.
Allow to send hashed email via config parameters
patmmccann
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Obtain hashed email from storage and make it part of the 33across ID request.
Include additional maintenance changes such as typo fixes and clearing storage items.