Core: support adAuctionHeaders #12542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patmmccann
approved these changes
Dec 5, 2024
|
@patmmccann is there any reason why we don't always send the header? |
|
@mkendall07 we only censor it on insecure You seem to be proposing changes to your adapter? |
|
@patmmccann no, I was thinking more about the PAAPI module enriching requests automatically vs having to have adapters update headers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description of change
Add support for the
adAuctionHeadersfetch option. Adapters can setoptions.adAuctionHeadersto true in the return value frombuildRequests, and the same flag will passed tofetch.Other information
Related to #12456 and #10740