Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akcelo bid adapter : initial release #12583

Merged
merged 2 commits into from
Dec 27, 2024
Merged

Akcelo bid adapter : initial release #12583

merged 2 commits into from
Dec 27, 2024
+468 −0

Conversation

rogerDyl
Copy link
Contributor

@rogerDyl rogerDyl commented Dec 16, 2024 •
edited
Loading

Type of change

  • [x ] New bidder adapter

Description of change

Adds the Akcelo bid adapter

  • Contact email of the adapter’s maintainer : [email protected]
  • Test parameters for validating bids:
{
  bidder: 'akcelo',
  params: {
    siteId: 763,
    adUnitId: 7965,
    test: 1,
  },
}

Other information

Documentation PR : prebid/prebid.github.io#5778

@rogerDyl rogerDyl mentioned this pull request Dec 16, 2024
Open
3 tasks
@ChrisHuie ChrisHuie requested a review from mmoschovas December 17, 2024 11:15
@ChrisHuie ChrisHuie removed the request for review from mmoschovas December 17, 2024 12:59
@patmmccann patmmccann self-requested a review December 27, 2024 20:48
@patmmccann patmmccann self-assigned this Dec 27, 2024
patmmccann
patmmccann reviewed Dec 27, 2024
View reviewed changes
modules/akceloBidAdapter.js
syncParams += `&gdpr_consent=${encodeURIComponent(gdprConsent.consentString || '')}`;
}
if (uspConsent) {
syncParams += `&us_privacy=${encodeURIComponent(uspConsent)}`;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably want gpp strings as well

@patmmccann patmmccann merged commit a88e801 into prebid:master Dec 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patmmccann patmmccann patmmccann approved these changes

Assignees

@patmmccann patmmccann

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rogerDyl @patmmccann @ChrisHuie @mmoschovas