-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rakuten bid adapter #5056
Rakuten bid adapter #5056
Conversation
Hey @snapwich. Can you explain how the typescript integration works? seems like you compiled it outside of prebid and then the prebid build will just use the JS version? Interesting pattern, not sure if that's a good idea or not.... |
modules/rakuten/index.ts
Outdated
height: sb.height || 0, | ||
creativeId: sb.creative_id || 0, | ||
dealId: sb.deal_id || '', | ||
currency: sb.currency || 'JPY', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default to 'USD'
Added a Typescript notice to the documentation. @mkendall07 yes that's what I did. This allows us to support types for the bid adapter interface without having to add typescript to the build process. It's possible we might want to add typescript to the build process, but that would be a backwards breaking change if we did. I should also add that this is pretty low maintenance required for us. The only tech debt we acquire with this methodology is needing to update the bidder factory or config type files if the interface changes. That should be infrequent and be more accurate than the current JSDocs types we keep. |
@snapwich Some questions
|
some other typescript options are:
I described it in a little more detail here: #5097 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Type of change
Description of change
New bidder adapter for Rakuten.
Also adds typescript types for bidder interface.
Other information
Bidder params update: prebid/prebid.github.io#1899