OpenRTB 2.6-202409 + AdCom v1.0-202409 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SyntaxNode
commented
Nov 20, 2024
•
SyntaxNode
commented
- OpenRTB 2.6-202409
- AdCom v1.0-202409
SyntaxNode
changed the title
SyntaxNode
commented
Nov 20, 2024
openrtb2/eid.go
Outdated
| // Description: | ||
| // Match method used by the matcher. Refer to List: Delivery Methods | ||
| // in AdCOM 1.0. | ||
| MM int64 `json:"mm,omitempty"` |
There was a problem hiding this comment.
Implementing as omitempty instead of a pointer following our "zero value has no meaning" convention.
bsardo
reviewed
Dec 4, 2024
openrtb2/eid.go
Outdated
| // Type: | ||
| // integer | ||
| // Description: | ||
| // Match method used by the matcher. Refer to List: Delivery Methods |
There was a problem hiding this comment.
Should this be "Refer to List: ID Match Methods"?
openrtb2/eid.go
Outdated
| // Description: | ||
| // Match method used by the matcher. Refer to List: Delivery Methods | ||
| // in AdCOM 1.0. | ||
| MM int64 `json:"mm,omitempty"` |
There was a problem hiding this comment.
Should the type be MatchMethod instead of int64?
bsardo
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.