Prebid plugin render changes #1068

OlenaPostindustria · 2024-12-03T12:54:45Z

jangirtony2009

@OlenaPostindustria Please take a look into the comments

jangirtony2009 · 2024-12-06T06:41:53Z

...MobileRendering/Prebid/PBMCacheRenderers/InterstitialController/InterstitialController.swift

+import UIKit
+
+@objcMembers
+public class InterstitialController:


@OlenaTeqBlaze this class needs to be open so that other renderers can create the child class and return it in PrebidMobileInterstitialPluginRenderer

This class is the SDK internal one. Could you please clarify the reason for needing to create the child classes? The current implementation of the plugin renderer indicates that you need to create your own class and conform it to PrebidMobilePluginRenderer protocol. You can use SampleRenderer as reference.

jangirtony2009 · 2024-12-06T06:49:09Z

...MobileRendering/Prebid/PBMCacheRenderers/InterstitialController/InterstitialController.swift

+        guard transactionFactory == nil else {
+            return
+        }
+
+        adConfiguration.adConfiguration.winningBidAdFormat = bid.adFormat
+        videoControlsConfig.initialize(with: bid.videoAdConfiguration)
+
+        // This part is dedicating to test server-side ad configurations.
+        // Need to be removed when ext.prebid.passthrough will be available.
+        #if DEBUG
+        adConfiguration.adConfiguration.videoControlsConfig.initialize(with: bid.testVideoAdConfiguration)
+        #endif
+
+        transactionFactory = PBMTransactionFactory(


If I inherit from InterstitialController, I need to override the loadAd method to receive the callback required for my renderer to load an ad. However, I cannot call super.loadAd because that would initiate the creation of the transactionFactory and start loading the prebid render ad. If i don't call it then bid.adFormat will not able to set.

Please, take a look at the comment above

PrebidMobile/PrebidMobileRendering/PluginRenderer/PrebidMobilePluginRegister.swift

PrebidMobile/PrebidMobileRendering/PluginRenderer/PrebidMobilePluginRenderer.swift

PrebidMobile/PrebidMobileRendering/Prebid/Integrations/GAM/AdLoading/PBMBannerAdLoader.m

...bid/PBMCacheRenderers/InterstitialController/InterstitialControllerInteractionDelegate.swift

...e/PrebidMobileRendering/Prebid/PBMCacheRenderers/DisplayView/PrebidDisplayViewRenderer.swift

YuriyVelichkoPI · 2024-12-06T08:28:58Z

@OlenaPostindustria Please take a look into the comments

Hi @jangirtony2009 ! Thanks for the review! We'll address your notes soon.

Please ignore the removed question if you saw it :)

OlenaPostindustria · 2024-12-10T13:32:54Z

Hi, @jangirtony2009! Thank you for taking the time to review this pull request!
Could you please take a look at the updates when you get a chance?

jangirtony2009 · 2024-12-13T07:59:21Z

PrebidMobile/PrebidMobileRendering/Prebid/Integrations/GAM/AdLoading/PBMBannerAdLoader.m

+
+    PBMLogWarn(@"SDK couldn't retrieve an implementation of PrebidMobileDisplayViewManagerProtocol. SDK will use the default one.");
+
+    PrebidRenderer *defaultRenderer = [PrebidRenderer new];


why are you creating the new object only for PrebidRenderer? Why not for the customRenderer?

The third-party renderer has the option to return nil when creating a banner or interstitial. In such cases, we must fall back to the default renderer, even if the "custom" renderer was originally selected.

Since Prebid will maintain the same object, developers won’t be able to manage local variables within the class. Therefore, it’s better to make the createBanner and createInterstitial methods static. This will provide more clarity to developers.

Hi @jangirtony2009 ! We'll make a small change in order not to create a separate instance of PrebidRenderer.

However, it doesn't look meaningful to make methods like createBanner static. The reason is that third-party renderers will still be passed to the SDK as objects.

Please review the following changes and let us know if they add clarity to the solution and workflow design.

jangirtony2009 · 2024-12-13T08:06:55Z

PrebidMobile/PrebidMobileRendering/PluginRenderer/PrebidMobilePluginRegister.swift

        }
+
+        return preferredPlugin
    }

    public func getAllPlugins() -> [PrebidMobilePluginRenderer] {


In prebid-android sdk is adding the default renderer in the adRequest and sending it to the server.

I'm not certain if we should do that, perhaps @YuriyVelichkoPI can help here.

Yes, we should register the default renderer in the list. It will be a good design approach. However, I'm not sure if SDK sends any signals indicating the presence of a default renderer. We'll double-check it.

@jangirtony2009, we checked the Android behavior and @ValentinPostindustria says that the SDK doesn't send any info about the default rendered in the request. So could you clarify this part of your comment

... and sending it to the server

Thanks!

…stitialControllerProtocol

…vided

… initialization

OlenaPostindustria force-pushed the prebid-plugin-render-changes branch from 3dd14b6 to d3b3e83 Compare December 5, 2024 08:59

OlenaPostindustria requested a review from YuriyVelichkoPI December 5, 2024 09:14

OlenaPostindustria marked this pull request as ready for review December 5, 2024 09:14

jangirtony2009 suggested changes Dec 6, 2024

View reviewed changes

OlenaPostindustria force-pushed the prebid-plugin-render-changes branch from f5f4fc1 to e868f09 Compare December 10, 2024 13:29

OlenaPostindustria requested a review from jangirtony2009 December 10, 2024 13:48

OlenaPostindustria force-pushed the prebid-plugin-render-changes branch 2 times, most recently from 7c7ba8e to 3f2d806 Compare December 10, 2024 14:05

jangirtony2009 suggested changes Dec 13, 2024

View reviewed changes

OlenaPostindustria force-pushed the prebid-plugin-render-changes branch 2 times, most recently from 02736b0 to 4b4e8d4 Compare December 19, 2024 08:23

OlenaPostindustria added 17 commits December 19, 2024 10:24

feat: ad view custom renderer prototype

09ea63c

feat: interstitial custom renderer prototype

4aad71f

feat: introduce PrebidMobileDisplayViewProtocol and PrebidMobileInter…

c1278ee

…stitialControllerProtocol

feat: send data in ORTB request

b7c956b

fix: plugin register unit tests

20425b2

tests: add request tests

f581e53

fix: missing winning ad format

2335040

feat: enhance InternalTestApp examples

e91c8f9

feat: add plugin renderer cases to demo apps

9cb12b1

feat: minor corrections

8e6097c

feat: unregister plugin renderer

d6dc040

fix: resolve issues after rebasing

07f55b8

feat: make universal Renderer protocol

50d0ec3

feat: change data property type & use default banner view if none pro…

2c7c89e

…vided

feat: remove isSupportRendering

00ea8db

feat: store SDK renderer in plugin array & register plugin during SDK…

4779cd0

… initialization

feat: restore .xcodeproj

7e8c7f5

feat: add log message in case default renderer wasn't found in registry

1ac4fd5

OlenaPostindustria force-pushed the prebid-plugin-render-changes branch from 4b4e8d4 to 1ac4fd5 Compare December 19, 2024 08:25

YuriyVelichkoPI requested a review from github-lucas-bon December 19, 2024 08:36

github-richard-depierre approved these changes Dec 20, 2024

View reviewed changes

jangirtony2009 approved these changes Dec 23, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prebid plugin render changes #1068

Prebid plugin render changes #1068

OlenaPostindustria commented Dec 3, 2024

jangirtony2009 left a comment

jangirtony2009 Dec 6, 2024

OlenaPostindustria Dec 10, 2024

jangirtony2009 Dec 6, 2024

OlenaPostindustria Dec 10, 2024

YuriyVelichkoPI commented Dec 6, 2024 •

edited

Loading

OlenaPostindustria commented Dec 10, 2024

jangirtony2009 Dec 13, 2024

OlenaPostindustria Dec 13, 2024

jangirtony2009 Dec 17, 2024

YuriyVelichkoPI Dec 17, 2024

jangirtony2009 Dec 13, 2024

OlenaPostindustria Dec 13, 2024

YuriyVelichkoPI Dec 17, 2024

YuriyVelichkoPI Dec 17, 2024 •

edited

Loading


		PBMLogWarn(@"SDK couldn't retrieve an implementation of PrebidMobileDisplayViewManagerProtocol. SDK will use the default one.");

		PrebidRenderer *defaultRenderer = [PrebidRenderer new];

Prebid plugin render changes #1068

Are you sure you want to change the base?

Prebid plugin render changes #1068

Conversation

OlenaPostindustria commented Dec 3, 2024

jangirtony2009 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YuriyVelichkoPI commented Dec 6, 2024 • edited Loading

OlenaPostindustria commented Dec 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YuriyVelichkoPI Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

YuriyVelichkoPI commented Dec 6, 2024 •

edited

Loading

YuriyVelichkoPI Dec 17, 2024 •

edited

Loading