Crash fix on bid.ext.prebid.meta getter in Bid.swift #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlenaPostindustria
requested changes
Feb 25, 2025
| @@ -88,12 +88,14 @@ public class Bid: NSObject { | |||
|
|
|||
| /// Preffered plugin renderer name | |||
| public var pluginRendererName: String? { | |||
| meta?[Bid.KEY_RENDERER_NAME] | |||
| guard let rendererName = meta?[Bid.KEY_RENDERER_NAME] as? String else { return nil } | |||
There was a problem hiding this comment.
You can just return meta?[Bid.KEY_RENDERER_NAME] as? String here
| } | ||
|
|
||
| /// Preffered plugin renderer version | ||
| public var pluginRendererVersion: String? { | ||
| meta?[Bid.KEY_RENDERER_VERSION] | ||
| guard let rendererVersion = meta?[Bid.KEY_RENDERER_VERSION] as? String else { return nil } |
|
@mdanylov-sigma @OlenaPostindustria @jangirtony2009, the unit tests fail every time. Do they work for this branch locally? If they work locally, It will be ok to merge. but need some proof. |
|
Let me check
…On Tue, Mar 11, 2025 at 1:28 PM Yuriy Velichko ***@***.***> wrote:
@mdanylov-sigma <https://github.com/mdanylov-sigma> @OlenaPostindustria
<https://github.com/OlenaPostindustria> @jangirtony2009
<https://github.com/jangirtony2009>, the unit tests fail every time. Do
they work for this branch locally? If they work locally, It will be ok to
merge. but need some proof.
—
Reply to this email directly, view it on GitHub
<#1108 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANBZHZ6E4BGWXCMBV7UYJT32T2JTXAVCNFSM6AAAAABXZZCI32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJTGA2TKMJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
[image: YuriyVelichkoPI]*YuriyVelichkoPI* left a comment
(prebid/prebid-mobile-ios#1108)
<#1108 (comment)>
@mdanylov-sigma <https://github.com/mdanylov-sigma> @OlenaPostindustria
<https://github.com/OlenaPostindustria> @jangirtony2009
<https://github.com/jangirtony2009>, the unit tests fail every time. Do
they work for this branch locally? If they work locally, It will be ok to
merge. but need some proof.
—
Reply to this email directly, view it on GitHub
<#1108 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANBZHZ6E4BGWXCMBV7UYJT32T2JTXAVCNFSM6AAAAABXZZCI32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMJTGA2TKMJSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1107