Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking URL #1112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Tracking URL #1112

wants to merge 1 commit into from

Conversation

mdanylov-sigma
Copy link
Collaborator

#954

  • Extends setCustomPrebidServer method with nonTrackingURL parameter.
  • Returns the PBS URL based on ATT status.

/// - Throws: An error if setting the custom host URL fails.
public func setCustomPrebidServer(url: String) throws {
public func setCustomPrebidServer(url: String, nonTrackingURL: String) throws {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will disrupt the existing integrations. I propose to add a separate method with an extra nonTrackingURL parameter.

@mdanylov-sigma mdanylov-sigma force-pushed the feature/954-tracking-domain branch from c7682f8 to 0948e3b Compare March 3, 2025 14:09
@YuriyVelichkoPI
Copy link
Contributor

I propose to implement this change on top of changes for #1006

The idea is the following:

  • Deprecate constants and provide a new initializeSDK method which will accept the host URL as a parameter (both platforms)
  • Introduce additional initialize SDK method with nonTrackingURL parameter.

After that, we will have a simple and clear initializtion interface.

The word Custom should be excluded from the initializtion interface since publisher will have to set the URL for any server without favorites.

If you think it make sense, please revisit the PR and make sure that we not only deprecate the usage of old constants but also provide an alternative initialization method where publishers will have to set the server URL directly. Also make sure that current initialization methods are marked as depricated.

@YuriyVelichkoPI
Copy link
Contributor

@mdanylov-sigma, since the #833 is merged, please rebase the branch and finalize changes according to the previous comment.

@mdanylov-sigma mdanylov-sigma force-pushed the feature/954-tracking-domain branch from 0948e3b to bded3e4 Compare March 11, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants