-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking URL #1112
base: master
Are you sure you want to change the base?
Tracking URL #1112
Conversation
/// - Throws: An error if setting the custom host URL fails. | ||
public func setCustomPrebidServer(url: String) throws { | ||
public func setCustomPrebidServer(url: String, nonTrackingURL: String) throws { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will disrupt the existing integrations. I propose to add a separate method with an extra nonTrackingURL
parameter.
c7682f8
to
0948e3b
Compare
I propose to implement this change on top of changes for #1006 The idea is the following:
After that, we will have a simple and clear initializtion interface. The word If you think it make sense, please revisit the PR and make sure that we not only deprecate the usage of old constants but also provide an alternative initialization method where publishers will have to set the server URL directly. Also make sure that current initialization methods are marked as depricated. |
@mdanylov-sigma, since the #833 is merged, please rebase the branch and finalize changes according to the previous comment. |
0948e3b
to
bded3e4
Compare
#954
setCustomPrebidServer
method withnonTrackingURL
parameter.