AudienceNetwork: Rename files #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SerhiiNahornyi
force-pushed
the
facebook-update
branch
from
32e0b8b to
ad78a79
Compare
SerhiiNahornyi
force-pushed
the
facebook-update
branch
from
ad78a79 to
87b2ee5
Compare
marki1an
reviewed
Sep 28, 2023
|
|
||
| private static final TypeReference<ExtPrebid<?, ExtImpFacebook>> FACEBOOK_EXT_TYPE_REFERENCE = | ||
| private static final TypeReference<ExtPrebid<?, ExtImpAudienceNetwork>> FACEBOOK_EXT_TYPE_REFERENCE = |
There was a problem hiding this comment.
Suggested change
| private static final TypeReference<ExtPrebid<?, ExtImpAudienceNetwork>> FACEBOOK_EXT_TYPE_REFERENCE = | |
| private static final TypeReference<ExtPrebid<?, ExtImpAudienceNetwork>> AUDIENCE_NETWORK_EXT_TYPE_REFERENCE = |
marki1an
reviewed
Sep 28, 2023
| @@ -130,36 +130,36 @@ private HttpRequest<BidRequest> makeHttpRequest(Imp imp, BidRequest bidRequest, | |||
| .build(); | |||
| } | |||
|
|
|||
| private ExtImpFacebook parseAndResolveExtImpFacebook(Imp imp) { | |||
| final ExtImpFacebook extImpFacebook; | |||
| private ExtImpAudienceNetwork parseAndResolveExtImpFacebook(Imp imp) { | |||
There was a problem hiding this comment.
Suggested change
| private ExtImpAudienceNetwork parseAndResolveExtImpFacebook(Imp imp) { | |
| private ExtImpAudienceNetwork parseAndResolveExtImpAudienceNetwork(Imp imp) { |
marki1an
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.