-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test: pb request correction
module
#3533
Merged
osulzhenko
merged 13 commits into
module/request-correction
from
tests/pb-request-correction-module
Nov 7, 2024
Merged
Test: pb request correction
module
#3533
osulzhenko
merged 13 commits into
module/request-correction
from
tests/pb-request-correction-module
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
requested changes
Oct 31, 2024
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
Comment on lines
12
to
16
@JsonProperty("pbsdk-android-instl-remove") | ||
Boolean interstitialCorrectionEnabled | ||
@JsonProperty("pbsdk-ua-cleanup") | ||
Boolean userAgentCorrectionEnabled | ||
Boolean enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have differences in our naming strategy. I agree that kebab-case is better for module consistency; however, we should confirm it, as it's an important part
prebid/prebid-server#3941
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
…ection' into tests/pb-request-correction-module
osulzhenko
requested changes
Nov 4, 2024
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
…le' into tests/pb-request-correction-module
osulzhenko
requested changes
Nov 4, 2024
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
...org/prebid/server/functional/tests/module/pbrequestcorrection/PbRequestCorrectionSpec.groovy
Outdated
Show resolved
Hide resolved
osulzhenko
approved these changes
Nov 5, 2024
…ection' into tests/pb-request-correction-module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
What's the context for the changes? Are there any
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check