Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: pb request correction module #3533

Merged

Conversation

marki1an
Copy link
Collaborator

@marki1an marki1an commented Oct 31, 2024

🔧 Type of changes

  • new bid adapter
  • update bid adapter
  • new feature
  • new analytics adapter
  • new module
  • bugfix
  • documentation
  • configuration
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes? Are there any

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hosts
  • geographic host parameters are NOT required
  • NO direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@marki1an marki1an added the tests Functional or other tests label Oct 31, 2024
@marki1an marki1an self-assigned this Oct 31, 2024
Comment on lines 12 to 16
@JsonProperty("pbsdk-android-instl-remove")
Boolean interstitialCorrectionEnabled
@JsonProperty("pbsdk-ua-cleanup")
Boolean userAgentCorrectionEnabled
Boolean enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have differences in our naming strategy. I agree that kebab-case is better for module consistency; however, we should confirm it, as it's an important part
prebid/prebid-server#3941

@osulzhenko osulzhenko merged commit e5a66a8 into module/request-correction Nov 7, 2024
@osulzhenko osulzhenko deleted the tests/pb-request-correction-module branch November 7, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants