Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pb-richmedia-filter global properties optional #3612

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

Net-burst
Copy link
Collaborator

@Net-burst Net-burst commented Dec 10, 2024

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

The pb-richmedia-filter module was requiring filter-mraid and mraid-script-pattern to be set globally. This is sometimes pointless.

🧠 Rationale behind the change

This change makes those properties optional so that module can be enabled globally, but configured per-account.

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

AntoxaAntoxic
AntoxaAntoxic previously approved these changes Dec 11, 2024
AntoxaAntoxic
AntoxaAntoxic previously approved these changes Dec 11, 2024
* Add functional test for empty config
@CTMBNara CTMBNara merged commit a5aa326 into master Dec 11, 2024
7 checks passed
@CTMBNara CTMBNara deleted the bugfix/pb-richmedia-filter-property-fix branch December 11, 2024 12:39
@Net-burst Net-burst changed the title Make pr-richmedia-filter global properties optional Make pb-richmedia-filter global properties optional Dec 11, 2024
sergseven pushed a commit to openx/prebid-server-java that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants