Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3574 add driftpixel userSync redirect url #3613

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

muuki88
Copy link
Contributor

@muuki88 muuki88 commented Dec 11, 2024

πŸ”§ Type of changes

  • configuration

✨ What's the context?

Ported from Go version: prebid/prebid-server#3973

🧠 Rationale behind the change

Keep bidder implementations in sync

πŸ§ͺ Test plan

🀞

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 11, 2024

Seems the currency service failed

2024-12-11T09:10:21.279Z  WARN 2065 --- [           main] o.p.s.c.CurrencyConversionService        : Error occurred while request to currency service

org.prebid.server.exception.PreBidException: HTTP status code 503
	at org.prebid.server.currency.CurrencyConversionService.processResponse(CurrencyConversionService.java:108)
	at io.vertx.core.impl.future.Mapping.onSuccess(Mapping.java:35)

@osulzhenko
Copy link
Collaborator

osulzhenko commented Dec 11, 2024

@muuki88 please update your redirect URL. It has some differences compared to Go version. You can refer to other bidders with similar configurations. For example, Vidoomy

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 12, 2024

Done

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 12, 2024

I'm confused why the tests fail πŸ™ˆ

@marki1an
Copy link
Collaborator

marki1an commented Dec 12, 2024

@muuki88 Hi, I found an issue that looks like:
Property: adapters.driftpixel.usersync.redirect.supportCors Value: "null" Reason: must not be null
Need to add adapters.driftpixel.usersync.redirect.support-cors: false/true
Please try to fix it, and then we will see if everything will be okay with the tests.

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 12, 2024

Thanks a lot @marki1an

I'll take a look. Should I research for a way to make the test output more accessible? There were quite a lot of exceptions that all seemed unrelated

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 13, 2024

APPLICATION FAILED TO START
***************************

Description:

Binding to target org.springframework.boot.context.properties.bind.BindException: Failed to bind properties under 'adapters.driftpixel' to org.prebid.server.spring.config.bidder.model.BidderConfigurationProperties failed:

    Property: adapters.driftpixel.usersync.redirect.supportCors
    Value: "null"
    Reason: must not be null


Action:

Update your application's configuration

Okay. This crashed the entire application start πŸ™ˆ

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 13, 2024

I'm not 100% sure that there are no external services involved πŸ˜…

org.prebid.server.hooks.modules.greenbids.real.time.data.v1.GreenbidsRealTimeDataProcessedAuctionRequestHookTest.callShouldFilterBiddersBasedOnModelWhenAnyFeatureNotAvailable -- Time elapsed: 2.842 s <<< ERROR!
java.io.FileNotFoundException: https://github.com/P3TERX/GeoLite.mmdb/releases/download/2024.12.13/GeoLite2-Country.mmdb

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 16, 2024

Thanks @AntoxaAntoxic for your patience πŸ™

I think there's still a problem unrelated to this change. I opened an issues #3629

@AntoxaAntoxic
Copy link
Collaborator

Please merge the latest master

@muuki88
Copy link
Contributor Author

muuki88 commented Dec 16, 2024

Hi @AntoxaAntoxic

Will do. Can you enable this setting? Then this would have been just a button click for anyone πŸ˜„
image

@AntoxaAntoxic
Copy link
Collaborator

@muuki88 Not sure I have the rights to do it. @Net-burst can you assist on that?

P.S. The failed test is not related to your changes, so please ignore.

@CTMBNara CTMBNara merged commit 3c319a9 into prebid:master Dec 17, 2024
7 checks passed
sergseven pushed a commit to openx/prebid-server-java that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: Driftpixel: Add default cookie sync endpoint
5 participants