Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GreenBids module: Ignore broken tests #3624

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

Net-burst
Copy link
Collaborator

@Net-burst Net-burst commented Dec 13, 2024

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

We overlooked that unit tests for GreenBid module were using a real world URL to pull a file from the internet. The file is no more, so tests now fail which breaks the build of the project.

🧠 Rationale behind the change

This is a quick and dirty "fix" until tests are properly updated by maintainer @EvgeniiMunin .

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@Net-burst
Copy link
Collaborator Author

@EvgeniiMunin FYI. Please fix this in your next PR. Also, unit tests should NOT depend on anything external. Because in cases like this, they will break the build of the whole project.

@Net-burst Net-burst added do not port tests Functional or other tests labels Dec 13, 2024
@Net-burst Net-burst changed the title Greenbids module: Ignore broken GreenBids tests GreenBids module: Ignore broken tests Dec 13, 2024
@Net-burst Net-burst merged commit f229d15 into master Dec 13, 2024
7 checks passed
@Net-burst Net-burst deleted the greenbids-igbore-broken-tests branch December 13, 2024 15:35
sergseven pushed a commit to openx/prebid-server-java that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not port tests Functional or other tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants