GitHub: codepath alerts #3645
Open
GitHub: codepath alerts #3645
+192
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osulzhenko
requested review from
And1sS and
CTMBNara
and removed request for
And1sS and
CTMBNara
osulzhenko
reviewed
Dec 27, 2024
| const refreshToken = process.env.OAUTH2_REFRESH_TOKEN; | ||
|
|
||
| // validate params | ||
| if (!repo || !prNumber || !token || !clientId || !clientSecret | !refreshToken) { |
There was a problem hiding this comment.
Is there a specific reason for using a bitwise OR operator (|) for refreshToken? It seems like a logical OR (||) might be more appropriate for this comparison, as we're checking the presence of multiple variables.
osulzhenko
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Allow adapters and module owners to register for alerts when a PR is opened against their code. See prebid/prebid-server#4075
I tested this over in the sourcecred repo and have set up the config file just for Index Exchange at this point. Working on Prebid documentation for it.