-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Digital Out Of Home (DOOH) Support #2532
Comments
Updated PBS First Party Doc to cover DOOH |
Confirming after a few meetings I've started preparing code and PR to deliver the above. |
We've started porting the Go PR to Java and have some questions. Maybe @SyntaxNode can route these? This feature pushes us to deal again with the lovely site/app incompatibility problem. We dealt with this in First Party Data processing. There are several places where site/app/dooh could end up conflicting:
Are all of these scenarios covered, and are they all draconian Kill-The-Request or do we pick one over another? Also, seems like PBS should automatically set ext.prebid.channel to "dooh" of that's the only one of the 3 objects present. Is that a thing? |
👍
A bid request is invalid if more than one of site/app/dooh is specified, regardless of it coming direct from a publisher or being the result of a stored request or First Party Data merge. I wouldn't characterize this approach negatively as "draconian". These objects describe the context/location of where the ad appears and it makes no sense for more than one to apply. The OpenRTB 2.6 spec is abundantly clear that "only one applies to a given bid request".
It's not a thing, but is a good callout. Let's make it a thing. |
Turns out I'd already updated the FPD doc with DOOH describing the "draconian" approach. BTW - we're good with dragons.
Cool. |
Note the DOOH contract is as follows -- will that be covered here?
If a bidder accepts requests with the |
Thanks @simontrasler . I'll let @minaguib and @SyntaxNode tackle in more detail, but my thinking is that the basic open source Prebid Server request/response signaling is ok as implemented. If any PBS host company wants to actually utilize DOOH, there are analytics and finance requirements they'll have to meet. @minaguib - the fact that bid adapters will have to resolve their own ORTB macros should be part of the documentation you were planning to write. |
@SyntaxNode - our team is testing the ported DOOH changes and pointed out that the metrics definition in the original request above is hard to understand and perhaps not in sync with what got implemented.
Besides these questions, I'm told that we see in the code is just these:
|
Implemented in PBS-Go 2.0 with exception of:
|
Done in PBS-Java. Includes FPD and DOOH channel. However, there's interim behavior where it's not rejecting site+app+dooh objects. That will be addressed in 3.0 because at this point it's a breaking change. |
Overview
OpenRTB 2.6-202211 introduced a new top level object for DOOH inventory alongside the existing App and Site objects. The Prebid DOOH Taskforce has requested for Prebid Server to add support.
OpenRTB Model Updates
The following new fields were added to the OpenRTB 2.x specification to support DOOH. Prebid Server must update its internal to add:
Prebid Server Code Changes
app
,dooh
, andsite
are provided.dooh
capability.dooh
impressions before calling a bidder, extending existing opt-in logic forapp
andsite
.dooh
channel type and auto populate todooh
when the value is not provided by a publisher.dooh.publisher
in addition toapp
andsite
.dooh
in the video endpoint data model. This endpoint is planned to be deprecated, but its strange IMHO to implement DOOH support everyone but here.dooh
following the same rules as exist today forapp
andsite
.dooh
inventory. In PBS-Go this includea:requests
with new labelrequests_without_cookie
request_time_seconds
with new labelrequests_without_cookie
requests_without_cookie
with new labelrequests_without_cookie
Adapter Code Changes
None required. Adapters already opt-in to which inventory types they support. Adding DOOH as an option will not require a code change until the adapter makes a choice to add support.
The text was updated successfully, but these errors were encountered: