New adapter: Ads Interactive #3929

AdsInteractive · 2024-09-17T21:54:27Z

github-actions · 2024-09-17T21:55:12Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 77fe565

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

przemkaczmarek · 2024-10-10T13:29:32Z

static/bidder-info/ads_interactive.yaml

@@ -0,0 +1,21 @@
+endpoint: "https://bntb.adsintreactive.com/"
+maintainer:
+  email: "[email protected]"


I have sent a email, please confirm

Please write back to my email. We need to confirm that this email works

przemkaczmarek · 2024-10-10T13:31:59Z

static/bidder-info/ads_interactive.yaml

@@ -0,0 +1,21 @@
+endpoint: "https://bntb.adsintreactive.com/"


endpoint is not reachable:

oops, there was an error in the domain, fixed

github-actions · 2024-10-11T08:31:58Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, ad4f8d5

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

github-actions · 2024-10-14T13:25:48Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 0cc30e3

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

przemkaczmarek · 2024-10-22T11:36:32Z

@bsardo we have already adsInteractive adapter. They use the same vendor-id

bsardo · 2024-10-24T14:31:15Z

@bsardo we have already adsInteractive adapter. They use the same vendor-id

@AdsInteractive we noticed that there is already an adsinteractive adapter in PBS with the same GVL ID and endpoint domain adsinteractive.com. We also see that there are two adapters in prebid.js for Ads Interactive. Can you help us understand why there are two?

AdsInteractive · 2024-10-28T10:21:19Z

@bsardo the existing adapter is used for one platform and this one is for ours. We have no relation to the existing adsinteractive

bsardo · 2024-11-04T16:48:17Z

Hi @AdsInteractive, we recently released PBS 3.0, more specifically v3.1.0, which updates Prebid Server package import references throughout the project from v2 to v3.
For example:

import (
    "github.com/prebid/prebid-server/v3/adapters"
)

As a result, please merge with master (no rebase) and then ensure all Prebid Server package import references in the files you’ve changed are v3 such that the test suite passes so we can resume reviewing. Thanks!

github-actions · 2024-11-05T14:26:40Z

Code coverage summary

Note:

Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
Coverage summary encompasses all commits leading up to the latest one, 46a6d48

ads_interactive

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:28:	Builder		100.0%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:35:	MakeRequests	88.2%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v3/adapters/ads_interactive/ads_interactive.go:145:	getBidType	100.0%
total:											(statements)	92.4%

AdsInteractive · 2024-11-05T14:27:22Z

@bsardo done

bretg · 2024-11-05T17:53:51Z

@AdsInteractive - I disagree with this statement:

We have no relation to the existing adsinteractive

The GVL ID is the same.
The contact address is the same

We need you to help us understand the actual relationship between adsinteractive and ads_interactive. There are 3 options:

ads_interactive is a new implementation and branding, and we should deprecate adsinteractive in a future major release.
ads_interactive is really the same company and this PR should be updated to just replace adsinteractive.
ads_interactive is truly a different company. You will provide different GVL ID and different contact address.

Based on the fact that this same confusion exists in Prebid.js, I suspect you'll choose option 1.

AdsInteractive · 2024-11-07T10:12:52Z

@bretg thanks for the reply, new clarifications have appeared. Our case is the first option: ads_interactive is a new implementation and branding, and we should deprecate adsinteractive in a future major release

bretg · 2024-11-07T14:05:50Z

I've added "remove adsinteractive adapter" to the PBS 4.0 issue. Please make sure that you update the documentation to make it clear which branding is active.

AdsInteractive · 2024-11-27T08:50:15Z

I've added "remove adsinteractive adapter" to the PBS 4.0 issue. Please make sure that you update the documentation to make it clear which branding is active.

@bretg thanks, doc PR - prebid/prebid.github.io#5732

przemkaczmarek · 2024-12-06T09:47:30Z

static/bidder-info/ads_interactive.yaml

@@ -0,0 +1,22 @@
+endpoint: "https://bntb.adsinteractive.com/"
+gvlVendorID: 1212


its correct:

"1212": { "id": 1212, "name": "Ads Interactive Ltd.", "purposes": [1, 2, 3, 4, 7, 10], "legIntPurposes": [], "flexiblePurposes": [], "specialPurposes": [1, 2], "features": [3], "specialFeatures": [], "overflow": { "httpGetLimit": 32 }, "cookieMaxAgeSeconds": 4838400, "usesCookies": true, "cookieRefresh": false, "urls": [ { "langId": "en", "privacy": "https://adsinteractive.com/privacy-policy", "legIntClaim": "https://adsinteractive.com/privacy-policy" } ], "usesNonCookieAccess": false, "dataRetention": { "stdRetention": 60, "purposes": { }, "specialPurposes": { } }, "dataDeclaration": [1, 2, 8, 11], "deviceStorageDisclosureUrl": "https://adsinteractive.com/vendor.json" } ```

przemkaczmarek · 2024-12-06T09:52:44Z

static/bidder-info/ads_interactive.yaml

@@ -0,0 +1,22 @@
+endpoint: "https://bntb.adsinteractive.com/"


not working

przemkaczmarek · 2024-12-06T10:57:44Z

adapters/ads_interactive/ads_interactive.go

+		var bidderExt adapters.ExtImpBidder
+		var adsInteractiveExt openrtb_ext.ImpExtAdsInteractive
+
+		if err := json.Unmarshal(imp.Ext, &bidderExt); err != nil {


Can you please switch this to using jsonutil? Starting in PBS 3.0 we're switching to our more optimized implementation. Thanks.

przemkaczmarek · 2024-12-06T11:02:20Z

adapters/ads_interactive/params_test.go

+	`{"placementId": "test"}`,
+	`{"placementId": "1"}`,
+	`{"endpointId": "test"}`,
+	`{"endpointId": "1"}`,


please handle:
{"placementId": "test", "unknownField": "value"},
{},
}

przemkaczmarek · 2024-12-06T11:03:09Z

adapters/ads_interactive/params_test.go

+var invalidParams = []string{
+	`{"placementId": 42}`,
+	`{"endpointId": 42}`,
+	`{"placementId": "1", "endpointId": "1"}`,


please handel:
{"placementId": ""},
{"endpointId": ""},
{"randomField": "value"},

VeronikaSolovei9 · 2024-12-17T04:18:25Z

adapters/ads_interactive/ads_interactive.go

+	reqCopy := *request
+	for _, imp := range request.Imp {
+		reqCopy.Imp = []openrtb2.Imp{imp}


I see you are creating a separate bid request per imp. Do you think it will make sense to move reqCopy := *request inside of the for loop?

AdsInteractive added 2 commits September 18, 2024 00:48

add new adapter ads_interactive

9f352ce

fix

77fe565

przemkaczmarek reviewed Oct 10, 2024

View reviewed changes

AdsInteractive added 2 commits October 11, 2024 11:30

Merge remote-tracking branch 'prebid/master'

85c07a0

fix domain

ad4f8d5

AdsInteractive requested a review from przemkaczmarek October 11, 2024 08:34

add gvlid

0cc30e3

przemkaczmarek self-assigned this Oct 14, 2024

AdsInteractive added 2 commits November 5, 2024 16:21

Merge remote-tracking branch 'prebid/master'

6b529e5

upd imports from v2 to v3

46a6d48

bsardo self-assigned this Nov 5, 2024

przemkaczmarek reviewed Dec 6, 2024

View reviewed changes

static/bidder-info/ads_interactive.yaml

@@ -0,0 +1,22 @@

endpoint: "https://bntb.adsinteractive.com/"

Copy link

Collaborator

przemkaczmarek Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not working

przemkaczmarek reviewed Dec 6, 2024

View reviewed changes

bsardo assigned VeronikaSolovei9 and unassigned bsardo Dec 16, 2024

VeronikaSolovei9 reviewed Dec 17, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New adapter: Ads Interactive #3929

New adapter: Ads Interactive #3929

AdsInteractive commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

przemkaczmarek Oct 10, 2024

przemkaczmarek Dec 6, 2024

przemkaczmarek Dec 12, 2024

przemkaczmarek Oct 10, 2024

AdsInteractive Oct 11, 2024

github-actions bot commented Oct 11, 2024

github-actions bot commented Oct 14, 2024

przemkaczmarek commented Oct 22, 2024

bsardo commented Oct 24, 2024

AdsInteractive commented Oct 28, 2024

bsardo commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

AdsInteractive commented Nov 5, 2024

bretg commented Nov 5, 2024

AdsInteractive commented Nov 7, 2024

bretg commented Nov 7, 2024

AdsInteractive commented Nov 27, 2024

przemkaczmarek Dec 6, 2024

przemkaczmarek Dec 6, 2024

przemkaczmarek Dec 6, 2024

przemkaczmarek Dec 6, 2024

przemkaczmarek Dec 6, 2024

VeronikaSolovei9 Dec 17, 2024

		@@ -0,0 +1,21 @@
		endpoint: "https://bntb.adsintreactive.com/"

		@@ -0,0 +1,22 @@
		endpoint: "https://bntb.adsinteractive.com/"
		gvlVendorID: 1212

New adapter: Ads Interactive #3929

Are you sure you want to change the base?

New adapter: Ads Interactive #3929

Conversation

AdsInteractive commented Sep 17, 2024

github-actions bot commented Sep 17, 2024

Code coverage summary

ads_interactive

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2024

Code coverage summary

ads_interactive

github-actions bot commented Oct 14, 2024

Code coverage summary

ads_interactive

przemkaczmarek commented Oct 22, 2024

bsardo commented Oct 24, 2024

AdsInteractive commented Oct 28, 2024

bsardo commented Nov 4, 2024

github-actions bot commented Nov 5, 2024

Code coverage summary

ads_interactive

AdsInteractive commented Nov 5, 2024

bretg commented Nov 5, 2024

AdsInteractive commented Nov 7, 2024

bretg commented Nov 7, 2024

AdsInteractive commented Nov 27, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment