Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smarthub: Update to Attekmi Endpoint #4047

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Smarthub: Update to Attekmi Endpoint #4047

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fbd042c
Smarthub: renaming Smarthub to Attekmi
SmartHubSolutions Nov 10, 2024
427eb60
fix https links
SmartHubSolutions Nov 10, 2024
eb11895
update test endpoints
SmartHubSolutions Nov 24, 2024
a85617e
update title and description
SmartHubSolutions Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthub_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import (

func TestJsonSamples(t *testing.T) {
bidder, buildErr := Builder(openrtb_ext.BidderSmartHub, config.Adapter{
Endpoint: "http://prebid.smart-hub.io/pbserver?partnerName={{.Host}}&seat={{.AccountID}}&token={{.SourceId}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})
Endpoint: "https://prebid.example.com/pbserver?partnerName={{.Host}}&seat={{.AccountID}}&token={{.SourceId}}"}, config.Server{ExternalUrl: "http://hosturl.com", GvlID: 1, DataCenter: "2"})

assert.NoError(t, buildErr)
adapterstest.RunJSONBidderTest(t, "smarthubtest", bidder)
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/exemplary/banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/exemplary/native.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/exemplary/video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/supplemental/bad-response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/supplemental/empty-seatbid-0-bid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/supplemental/empty-seatbid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/supplemental/status-204.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/supplemental/status-400.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/supplemental/status-503.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/supplemental/unexpected-status.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion adapters/smarthub/smarthubtest/supplemental/wrong-bidtype.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"httpCalls": [
{
"expectedRequest": {
"uri": "http://prebid.smart-hub.io/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"uri": "https://prebid.example.com/pbserver?partnerName=partnertest&seat=9Q20EdGxzgWdfPYShScl&token=zpl5iB5Ugpe9ofVTzi44WzfjZZYq1yer",
"body": {
"id": "id",
"imp": [
Expand Down
2 changes: 1 addition & 1 deletion static/bidder-info/felixads.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
endpoint: "http://felixads-prebid.smart-hub.io/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
endpoint: "https://felixads-prebid.attekmi.com/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
aliasOf: "smarthub"
2 changes: 1 addition & 1 deletion static/bidder-info/jdpmedia.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
endpoint: "http://jdpmedia-prebid.smart-hub.io/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
endpoint: "https://jdpmedia-prebid.attekmi.com/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
aliasOf: "smarthub"
userSync:
supports:
Expand Down
2 changes: 1 addition & 1 deletion static/bidder-info/markapp.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
endpoint: "http://markapp-prebid.smart-hub.io/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
endpoint: "https://markapp-prebid.attekmi.com/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
aliasOf: "smarthub"
userSync:
supports:
Expand Down
6 changes: 3 additions & 3 deletions static/bidder-info/smarthub.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
endpoint: "http://prebid.smart-hub.io/pbserver?partnerName={{.Host}}&seat={{.AccountID}}&token={{.SourceId}}"
endpoint: "https://prebid.attekmi.com/pbserver?partnerName={{.Host}}&seat={{.AccountID}}&token={{.SourceId}}"
maintainer:
email: "[email protected]"
email: "[email protected]"
capabilities:
SmartHubSolutions marked this conversation as resolved.
Show resolved Hide resolved
app:
mediaTypes:
Expand All @@ -13,7 +13,7 @@ capabilities:
- video
- native
userSync:
# smarthub supports user syncing, but requires configuration by the host. contact this
# Attekmi supports user syncing, but requires configuration by the host. contact this
# bidder directly at the email address in this file to ask about enabling user sync.
SmartHubSolutions marked this conversation as resolved.
Show resolved Hide resolved
supports:
- redirect
2 changes: 1 addition & 1 deletion static/bidder-info/tredio.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
endpoint: "http://tredio-prebid.smart-hub.io/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
endpoint: "https://tredio-prebid.attekmi.com/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
aliasOf: "smarthub"
userSync:
supports:
Expand Down
2 changes: 1 addition & 1 deletion static/bidder-info/vimayx.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
endpoint: "http://vimayx-prebid.smart-hub.io/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
endpoint: "https://vimayx-prebid.attekmi.com/pbserver/?seat={{.AccountID}}&token={{.SourceId}}"
aliasOf: "smarthub"
6 changes: 3 additions & 3 deletions static/bidder-params/smarthub.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
{
"$schema": "http://json-schema.org/draft-04/schema#",
"title": "SmartHub Adapter Params",
"description": "A schema which validates params accepted by the SmartHub adapter",
"title": "Attekmi Adapter Params",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "Attekmi Adapter Params",
"title": "Attekmi (formerly SmartHub) Adapter Params",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed title

"description": "A schema which validates params accepted by the Attekmi adapter",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "A schema which validates params accepted by the Attekmi adapter",
"description": "A schema which validates params accepted by the Attekmi (formerly SmartHub) adapter",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed description

"type": "object",
"properties": {
"partnerName": {
"type": "string",
"description": "SmartHub unique partner name",
"description": "Attekmi unique partner name",
SmartHubSolutions marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Attekmi unique partner name",
"description": "Attekmi (formerly SmartHub) unique partner name",

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I changed description

"minLength": 1
},
"seat": {
Expand Down
Loading