-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In order to protect users of prebid-server that don't use CGO, add build flag #4058
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the additions and looks good with the changes from @justadreamer.
@bsardo - how can we move this forward? |
@linux019 - You commented on this PR. Do you wish to re-review? |
@SyntaxNode If the PBS cannot be run without CGO - don't allow to build the image instead of raising a panic or exclude compiler-depended code
|
fe07dc4
to
f996399
Compare
@SyntaxNode @linux019 - please take another look - the fiftyonedegrees module is excluded in its entirety now (though, there still needs to be cgo and !cgo files in the modules for the builder to conditionally configure it. |
"fiftyonedegrees": { | ||
"devicedetection": fiftyonedegreesDevicedetection.Builder, | ||
}, | ||
ret := ModuleBuilders{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is autogenerated by
Line 23 in f3b5bce
go generate modules/modules.go |
Changes between v2.30.0...v2.31.0 force users to use CGO, even if not using the 51degrees module. This change adds the cgo flag to enable bringing in prebid-server without this requirement.