Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blue: Add bidFloor and currency param. Change current values configuration. #4115

Closed
wants to merge 10 commits into from
Closed

Blue: Add bidFloor and currency param. Change current values configuration. #4115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e2b6f8e
Add a new property called "placementId" to the Blue adapter params sc…
samuelfabel Nov 12, 2024
886bf03
Merge branch 'prebid:master' into master
samuelfabel Nov 23, 2024
0d9fd7f
Inclusão de teste de parametro
samuelfabelopencircle Nov 23, 2024
a8e2584
Include param tests to blue adapters
samuelfabelopencircle Nov 23, 2024
d32141c
Merge branch 'master' of https://github.com/samuelfabel/prebid-server
samuelfabelopencircle Nov 23, 2024
072d686
Add new test cases for Blue bidder parameter validation
samuelfabelopencircle Dec 4, 2024
6832432
Merge branch 'prebid:master' into master
samuelfabel Dec 4, 2024
cc249e1
Merge branch 'prebid:master' into master
samuelfabel Dec 14, 2024
711022f
Merge branch 'prebid:master' into master
samuelfabel Dec 18, 2024
bec988b
Blue: Add bidFloor and currency param. Change current values configur…
samuelfabelopencircle Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions adapters/blue/params_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,8 @@ func TestInvalidParams(t *testing.T) {
}

var validParams = []string{
`{"publisherId":"1234"}`,
`{"publisherId":"1234", "placementId":"12345"}`,
`{"publisherId":"", "placementId":""}`,
`{"publisherId":"1234", "placementId":"12345","bidFloor":1,"currency":"USD"}`,
`{"publisherId":"", "placementId":"","bidFloor":0,"currency":""}`,
}

var invalidParams = []string{
Expand All @@ -47,5 +46,11 @@ var invalidParams = []string{
`4.2`,
`[]`,
`{}`,
`{"placementId":"12345"}`,
`{"placementId":"12345","bidFloor":1,"currency":"USD"}`,
`{"publisherId":"1234", "bidFloor":1,"currency":"USD"}`,
`{"publisherId":"1234", "placementId":"12345","currency":"USD"}`,
`{"publisherId":"1234", "placementId":"12345","bidFloor":1}`,
`{"publisherId":"Y9Evrh40ejsrCR4EtidUt1cSxhJsz8X1", "placementId":"12345","bidFloor":1,"currency":"USD"}`,
`{"publisherId":"1234", "placementId":"alNYtemWggraDVbhJrsOs9pXc3Eld32E","bidFloor":1,"currency":"USD"}`,
`{"publisherId":"1234", "placementId":"12345","bidFloor":1,"currency":"Bq7PfZuLxKcMnT5RwV2Gy9AoHiJD4S6F"}`,
}
20 changes: 17 additions & 3 deletions static/bidder-params/blue.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,28 @@
"properties": {
"placementId": {
"type": "string",
"description": "Placement ID provided by Blue"
"description": "Placement ID provided by Blue",
"maxLength": 30
},
"publisherId": {
"type": "string",
"description": "The publisher’s ID provided by Blue"
"description": "The publisher’s ID provided by Blue",
"maxLength": 30
},
"bidFloor": {
"type": "number",
"description": "The bid floor value provided by Blue"
},
"currency": {
"type": "string",
"description": "The currency code provided by Blue",
"maxLength": 30
}
},
"required": [
"publisherId"
"placementId",
"publisherId",
"bidFloor",
"currency"
]
}
Loading