Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opsco Bid Adapter Documentation #5162

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

ops-co
Copy link
Contributor

@ops-co ops-co commented Feb 19, 2024

🏷 Type of documentation

  • new bid adapter

📋 Checklist

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 9cdcae8
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/65f41269ddcab700080a39aa
😎 Deploy Preview https://deploy-preview-5162--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@muuki88 muuki88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the missing meta data fields. Otherwise it looks good.

dev-docs/bidders/opsco.md Outdated Show resolved Hide resolved
| `siteId` | optional | The Site ID | `'123'` | `string` |
| `test` | optional | Whether the request is for testing only. | `true` | `boolean` |


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the lint issue 😄

Copy link
Contributor

@adtech-sky adtech-sky Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muuki88 The issue is resolved. When can we expect it to be merged? Because our adapter is merged in 8.40 without the docs. Thanks

@adtech-sky
Copy link
Contributor

@muuki88 Any updates on this?

@muuki88 muuki88 added LGTM and removed needs work labels Apr 10, 2024
@muuki88 muuki88 merged commit 234c56f into prebid:master Apr 10, 2024
4 of 5 checks passed
@muuki88
Copy link
Contributor

muuki88 commented Apr 10, 2024

Thanks for the ping 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants