Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Add section about ad position configuration #5751

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Conversation

OlenaPostindustria
Copy link
Contributor

@OlenaPostindustria OlenaPostindustria commented Dec 5, 2024

🏷 Type of documentation

  • new bid adapter
  • update bid adapter
  • new feature
  • text edit only (wording, typos)
  • bugfix (code examples)
  • new examples

The issue in the mobile repo: prebid/prebid-mobile-ios#1065

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for prebid-docs-preview ready!

Name Link
🔨 Latest commit 5a00088
🔍 Latest deploy log https://app.netlify.com/sites/prebid-docs-preview/deploys/67519ab874ca850008404f74
😎 Deploy Preview https://deploy-preview-5751--prebid-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


You can set `adPosition` by using the following method:

```kotlin
Copy link
Contributor

@muuki88 muuki88 Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the right time to start this, but there is a custom component "code/mobile-sdk.html":

https://docs.prebid.org/docs-examples/tab-example.html

This would allow you to write the documentation once and put the code into this tabbing component. From my perspective it would hurt that one would see both code examples.

Instead of writing the same text four times and the code examples twice, this could be one include

@bretg what are your thoughts on this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, not following @muuki88 -- there's only one code example here, not sure why we'd need the tabbing component? Maybe the idea is that ios and android should be one file with the tab approach? That was debated, but unfortunately there are other differences between ios and android sometimes that make it harder to split. The mobile folks pointed to other web site documentation where ios and android were separate pages and suggested that's The Way Things Are Done (tm)

@YuriyVelichkoPI
Copy link
Contributor

@bretg @muuki88 this PR can be merged, the respective changes are released

@muuki88 muuki88 merged commit 0f74f8b into master Dec 20, 2024
5 checks passed
@muuki88 muuki88 deleted the mobile/ad-position branch December 20, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants