-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile: Add section about ad position configuration #5751
Conversation
✅ Deploy Preview for prebid-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
||
You can set `adPosition` by using the following method: | ||
|
||
```kotlin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the right time to start this, but there is a custom component "code/mobile-sdk.html":
https://docs.prebid.org/docs-examples/tab-example.html
This would allow you to write the documentation once and put the code into this tabbing component. From my perspective it would hurt that one would see both code examples.
Instead of writing the same text four times and the code examples twice, this could be one include
@bretg what are your thoughts on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, not following @muuki88 -- there's only one code example here, not sure why we'd need the tabbing component? Maybe the idea is that ios and android should be one file with the tab approach? That was debated, but unfortunately there are other differences between ios and android sometimes that make it harder to split. The mobile folks pointed to other web site documentation where ios and android were separate pages and suggested that's The Way Things Are Done (tm)
🏷 Type of documentation
The issue in the mobile repo: prebid/prebid-mobile-ios#1065