Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance and test pre cice configuration formatter #91

Draft
wants to merge 52 commits into
base: main
Choose a base branch
from
Draft

enhance and test pre cice configuration formatter #91

wants to merge 52 commits into from

Conversation

Toddelismyname
Copy link
Contributor

Fixed some errors in formatter and made it possible to disable it via cli.

@Toddelismyname
Create global list of valid convergence measure tags and use it (temp…
b998725 
…arary adding hook script in again)
@Toddelismyname
Improve coupling-scheme XML printing to include all elements
f4f7840 
Before that ['participants', 'max-time', 'time-window-size'] were not printed
@Toddelismyname
Revert "Improve coupling-scheme XML printing to include all elements"
3fd564c 
This reverts commit f4f7840.
@Toddelismyname
Add TODO to print all other elements like max-iterations after a new …
df411b6 
…line after initial elements and not efter exchanges
@Toddelismyname
First idea to remove already printed things from other elements and t…
06c2dc4 
…hen print it
@Toddelismyname
Print all other elements
419f84f
@Toddelismyname
add or other_elements in format.py and apply changes to format_precic…
907ad9c 
…e... too
@Toddelismyname
add newline after initial elements
b41392e
@Toddelismyname
make it possible to disable formatting for whatever reason
9749782
@Toddelismyname
Remove temp format file in pre-commit hook style after changes were a…
533ef1b 
…pplied there
@Toddelismyname Toddelismyname added enhancement New feature or request Fix Fixing a bug/error labels Feb 6, 2025
@Toddelismyname Toddelismyname self-assigned this Feb 6, 2025
@Toddelismyname Toddelismyname linked an issue Feb 6, 2025 that may be closed by this pull request
Enhance and Test preCICE Configuration Formatter #90
Open
@Toddelismyname Toddelismyname marked this pull request as ready for review February 6, 2025 16:41
@Toddelismyname Toddelismyname marked this pull request as draft February 8, 2025 08:52
@Toddelismyname
Implement attribute sorting with 'name' first
77e1e6f 
example input 1:
<write-data name="Force" mesh="Fluid-Mesh"/>
And example input 2:
<write-data mesh="Fluid-Mesh" name="Force"/>
should both return:
<write-data name="Force" mesh="Fluid-Mesh"/>
@Toddelismyname
always sort attributes alphabetically, with 'name' as a special case
9623280
@Toddelismyname
Also sort mapping elements
2858fbb
@Toddelismyname
apply changes done in format.py to our file that gets called
5f6383f
@Toddelismyname
Fix issues:
76c99f8 
The custom_sort_key() function is now a global function, but it's being used as if it were a method.
The participant_order variable is not defined.
@Toddelismyname
Check if formatting does not throw errors
ad6a827
@Toddelismyname
Compare line by line approach start
a084b87
@Toddelismyname
Fix: format is a dated import
1c0c9fb
@Toddelismyname
Revert "Fix: format is a dated import"
7068995 
This reverts commit 1c0c9fb.
@Toddelismyname
Do real line by line for now
61ec5a1
@Toddelismyname
sort stuff with the same name alphabetically by their first common at…
5ba8661 
…tribute value
@Toddelismyname
Remove unused imports
0151ca1
@Toddelismyname
normalize closing tags and tailing whitespaces so this is not an erro…
905de17 
…r anymore:

E           AssertionError: Mismatch:
E             Original: <data:vector name="Displacement"/>
E             Generated: <data:vector name="Displacement" />
@Toddelismyname
Also normalize spaces between tag name and first attribute
0a6a096
@Toddelismyname
Move to normalize xml line func
3fce4f8
@Toddelismyname
preserve the original indentation
ba0efd1
@Toddelismyname
ignore indentation and only care about the parent tag's depth
2a0fb7e
@Toddelismyname
ignore whitespace differences
494dcfd
@Toddelismyname
print formatted file to see where error is ?
d349a9d
@Toddelismyname
add operation that does: Sort XML elements with the same name by thei…
9fa76c4 
…r first common attribute value alphabetically
@Toddelismyname
Revert "add operation that does: Sort XML elements with the same name…
441455d 
… by their first common attribute value alphabetically"

This reverts commit 9fa76c4.
@Toddelismyname
only add func for now
8250ac5
@Toddelismyname
Call it in the end and group by depth
8c15ccb
@Toddelismyname
fix indentation error
49d8aaf
@Toddelismyname
Group elements by their tag name and parent tag name and parent attri…
0184358 
…butes
@Toddelismyname
Revert "Group elements by their tag name and parent tag name and pare…
ac621a8 
…nt attributes"

This reverts commit 0184358.
@Toddelismyname
Revert "fix indentation error"
7b2e39c 
This reverts commit 49d8aaf.
@Toddelismyname
Revert "Call it in the end and group by depth"
8e24b3b 
This reverts commit 8c15ccb.
@Toddelismyname
Revert "only add func for now"
7397686 
This reverts commit 8250ac5.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VanLaareN VanLaareN Awaiting requested review from VanLaareN

At least 1 approving review is required to merge this pull request.

Assignees

@Toddelismyname Toddelismyname

Labels
enhancement New feature or request Fix Fixing a bug/error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance and Test preCICE Configuration Formatter
1 participant
@Toddelismyname