Add Contents.m file #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminRodenberg
approved these changes
Oct 14, 2020
There was a problem hiding this comment.
Looks like a good solution to me (for the sake of closing #24). Not perfect, since the ver precice would be a nice feature and I assume Contents.m provides more features that might be useful, but good enough for now.
IshaanDesai
added a commit
that referenced
this pull request
Nov 9, 2020
* Fix typo * Add data transfer to solverdummy (#20) * Add Contents.m file (#25) * Adding Contents.m file to store version * Adding all tested versions of MATLAB to Contents file * Bump version Co-authored-by: Benjamin Rüth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Contents.m file for the bindings. This file is used to store version number and also information which the user can query with the
helpcommand in MATLAB.After compiling the bindings the output of
veris as follows:It can be seen that the MATLAB-bindings and the version number are now included in the list.
Unfortunately adding the Contents file to the +precice folder to enable a query like
ver precicedoes not work and throws the error:This has been resolved yet. Putting a Contents file in the main folder of the bindings is the simplest working solution yet to store the Version number.
This PR closes #24