Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in handling of vector data #143

Merged
merged 7 commits into from
Jan 27, 2025
Merged

Fix bug in handling of vector data #143

merged 7 commits into from
Jan 27, 2025

Conversation

IshaanDesai
Copy link
Member

@IshaanDesai IshaanDesai commented Jan 24, 2025

The Micro Manager could not handle the case where a micro simulation returns vector data in the form of a list. This was because the data collection for adaptivity was done on a predefined numpy.array data structure. Now the data collection is done in a Python list and the list is converted to a NumPy array only just before the data is used for the similarity calculation.

Checklist:

  • I made sure that the CI passed before I ask for a review.
  • I added a summary of the changes (compared to the last release) in the CHANGELOG.md.
  • I will remember to squash-and-merge, providing a useful summary of the changes of this PR.

@IshaanDesai IshaanDesai added the bug Something isn't working label Jan 24, 2025
@IshaanDesai IshaanDesai self-assigned this Jan 24, 2025
@IshaanDesai IshaanDesai linked an issue Jan 27, 2025 that may be closed by this pull request
Copy link
Collaborator

@mathiskelm mathiskelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes issue #144 also in my application. Looks good!

@IshaanDesai IshaanDesai merged commit c2eefed into develop Jan 27, 2025
11 checks passed
@IshaanDesai IshaanDesai deleted the fix-vec-data branch January 27, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot use vector-valued output of micro simulations in adaptivity
2 participants