Move adaptivity CPU time output from preCICE export to metrics logging #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IshaanDesai
changed the title
IshaanDesai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is made because the adaptivity computation CPU time is not a micro simulation specific data, but just one single global data (for global adaptivity). For local adaptivity, the CPU time is unique for every rank, and it is probably a good idea to aggregate the data and output it. The CPU time is now calculated by default, and written to the
adaptivity-metrics.csvfile instead of being exported using the preCICE export functionality.Checklist:
CHANGELOG.md.