Fix approx_percentile to have constant pct for input rows #24600
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See full context here: #24592
Add validation to ensure that the percentile used in
approx_percentile
is constant between all rows.Motivation and Context
approx_percentile was using the last percentile in the input rows used for aggregation; however, the percentile argument should be constant between the rows for the aggregation as per the Presto documentation.
See: #24592
Impact
Users who leverage this function may now see errors if they were passing in non constant percentiles between the rows. For example, the following query will now throw whereas before, it would use 0.9 as the percentile value.
Test Plan
Added unit test and also manual test via Presto-cli
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: