Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy content from primer.style/desktop → primer.style/design #365

Merged
merged 5 commits into from
Feb 2, 2023

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Jan 25, 2023

Closes https://github.com/github/primer/issues/1615

Questions :)

@broccolinisoup broccolinisoup temporarily deployed to github-pages January 25, 2023 06:42 — with GitHub Actions Inactive
@broccolinisoup
Copy link
Member Author

@emilybrick it is giving me an error because I used the same title but different sections. https://github.com/DavidAnson/markdownlint/blob/v0.26.2/doc/Rules.md#md024

I don't know how to pass parameters to the markdown so that it allows the same heading in the siblings 🤔

@broccolinisoup broccolinisoup marked this pull request as ready for review January 25, 2023 06:53
@broccolinisoup broccolinisoup requested a review from a team as a code owner January 25, 2023 06:53
@emilybrick
Copy link
Contributor

emilybrick commented Jan 25, 2023

Hey! Answering some questions:

I added index.mdx for /native and /desktop but I am not sure if we need them? 🤔

The only content you need on the index.mdx for /desktop are links to Getting Started + Foundations. Similar to how they are laid out here with a heading.

The index.mdx content on /native should also be similar to /guides - just links to the content in that section (if for now it's just desktop, that's fine). It's just a catch-all so we don't dead end folks who happen to hit the url. I can help with writing some super short descriptions under the text.

Do we need ToC as we have the sections on the right hand side?

I would remove this list of links that are on the top of this page, so that we only have the ToC here

Screen Shot 2023-01-25 at 12 43 44 PM

@broccolinisoup
Copy link
Member Author

broccolinisoup commented Jan 27, 2023

Asked the question about the linting rule to #accessibility (slack ref)

Update: 30th Jan Monday

I received a response from the accessibility team on how to pass parameters to allow same headings for different parents but it is a little tricky as we have an issue with the duplicated heading links on the doctocat theme. the links gets messed up if you click on one of the same headings or share it. They also recommended to change the titles to have different text. i.e. "Button order on MacOS".

I was thinking we can change the titles to have different text to make them accessible and in the meantime we can see if we can look into the doctocat theme issue and see if we can come up with a solution for it. How does that sound? @emilybrick

@emilybrick
Copy link
Contributor

I was thinking we can change the titles to have different text to make them accessible and in the meantime we can see if we can look into the doctocat theme issue and see if we can come up with a solution for it.

☝️ sorry for the delay here, this sounds like the best option to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants