Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export Layout component from package #724

Closed
wants to merge 2 commits into from

Conversation

joshfarrant
Copy link

Exports the layout component so it can be imported from the main package, eg

// Enables this
import {Layout} from '@primer/gatsby-theme-doctocat'

// So we don't have to do this
import Layout from '@primer/gatsby-theme-doctocat/src/components/layout'

@joshfarrant joshfarrant requested a review from a team as a code owner April 16, 2024 08:08
@joshfarrant joshfarrant requested a review from owenniblock April 16, 2024 08:08
Copy link

changeset-bot bot commented Apr 16, 2024

🦋 Changeset detected

Latest commit: a35cc9b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/gatsby-theme-doctocat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@owenniblock owenniblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🎉

@owenniblock
Copy link
Contributor

owenniblock commented Apr 16, 2024

That error on the build looked unrelated so I'm just rerunning to see what happens.

UPDATE: Nope, still broken 🙁 @joshfarrant not sure what's causing that (outside my area of expertise) but if you can't work it out and want to look at it together let me know.

@joshfarrant
Copy link
Author

Thank you for taking a look at the PR @owenniblock, much appreciated 🙌

It looks like something broke a while ago — the majority of the most recent PRs have all had the same issue. The error that gets thrown up in CI is related to the project using v6 of Styled Components, but using an API (withComponent) which was deprecated in v4 and has now been removed. Dependabot bumped the version a while ago, but things might have been broken before then. Fixing that issue just throws up another error though, and I'm not sure how long that chain could be.

I'll close this PR for now and may come back to it further down the line 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants