-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracking header #726
Add tracking header #726
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me, just one question on how the tracking here works and whether we need a cookie notification.
@@ -15,6 +15,12 @@ function Head(props) { | |||
<meta property="og:description" content={description} /> | |||
<meta property="og:image" content={siteMetadata.imageUrl} /> | |||
<meta property="twitter:card" content="summary_large_image" /> | |||
{siteMetadata.primerTracking ? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this use cookies at all? If so do we need to add a cookie notification when siteMetadata.primerTracking is true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. This variant is only sending basic information as an event on page load that does not rely on anything stored in a cookie.
Adding two lines to the
<head>
of all primer.style pages to determine usage.