Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tracking header #726

Merged
merged 11 commits into from
Apr 19, 2024
Merged

Add tracking header #726

merged 11 commits into from
Apr 19, 2024

Conversation

dipree
Copy link
Contributor

@dipree dipree commented Apr 17, 2024

Adding two lines to the <head> of all primer.style pages to determine usage.

@dipree dipree requested a review from a team as a code owner April 17, 2024 13:31
@dipree dipree requested a review from TylerJDev April 17, 2024 13:31
Copy link

changeset-bot bot commented Apr 17, 2024

⚠️ No Changeset found

Latest commit: c2314b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@owenniblock owenniblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, just one question on how the tracking here works and whether we need a cookie notification.

@@ -15,6 +15,12 @@ function Head(props) {
<meta property="og:description" content={description} />
<meta property="og:image" content={siteMetadata.imageUrl} />
<meta property="twitter:card" content="summary_large_image" />
{siteMetadata.primerTracking ? (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this use cookies at all? If so do we need to add a cookie notification when siteMetadata.primerTracking is true?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. This variant is only sending basic information as an event on page load that does not rely on anything stored in a cookie.

@dipree dipree merged commit 5fe6bf8 into main Apr 19, 2024
5 checks passed
@dipree dipree deleted the tracking-header branch April 19, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants