Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add square-circle icons #1063

Merged
merged 8 commits into from
Feb 4, 2025
Merged

Add square-circle icons #1063

merged 8 commits into from
Feb 4, 2025

Conversation

dylanatsmith
Copy link
Contributor

This PR adds square-circle-16 and square-circle-24 to be used in github.com surface areas inside IconButton as stop buttons. Consensus is that the existing square-fill can be too ambiguous.

Naming square-circle was chosen to be consistent with x-circle and plus-circle.

Note: @CameronFoxly chose the 0.75px corner radius for the 16px icon.

Source file

@dylanatsmith dylanatsmith self-assigned this Jan 31, 2025
@dylanatsmith dylanatsmith requested a review from a team as a code owner January 31, 2025 17:11
@dylanatsmith dylanatsmith requested a review from tallys January 31, 2025 17:11
Copy link

changeset-bot bot commented Jan 31, 2025

🦋 Changeset detected

Latest commit: eea3d04

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/octicons Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylanatsmith dylanatsmith requested a review from a team as a code owner January 31, 2025 17:17
Copy link
Contributor

@CameronFoxly CameronFoxly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Approved once we fix those build fail issues

@dylanatsmith
Copy link
Contributor Author

Opened #1064 to fix the CI failure

@francinelucca francinelucca merged commit 6481783 into main Feb 4, 2025
11 checks passed
@francinelucca francinelucca deleted the dylanatsmith/square-circle branch February 4, 2025 16:29
@primer primer bot mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants