-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add multigrid #425
Open
landinjm
wants to merge
54
commits into
prisms-center:devel
Choose a base branch
from
landinjm:add_multigrid
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[WIP] Add multigrid #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
landinjm
force-pushed
the
add_multigrid
branch
from
February 4, 2025 16:18
8115bda
to
3c4a89b
Compare
There's a few internal benchmarks that would be good to test the performance of our software.
@fractalsbyx @david-montiel-t @zachcroft @wband Any other thoughts here? |
For 3), I expect that most problems that have time-dependent boundary conditions would benefit from them being updated/enforced at every step. For fracture it's the main factor driving evolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issues that this covers:
#424 Done. Has a unit test
#419
#418
#409 Mostly done.
#407
#406
#399 Mostly done.
#394 Class done. Need to add output
#392
#391
#390
#366 Done.
#351
#329 Done. Need to fix up a few more complexity issues.
#326
#323
#318
#314
#313 Done. Needs a unit test or application test.
#311 Done for scalar fields. Needs some warnings when not placed at a vertex.
#309
#308
#299
#294 Done. Needs a few finishing touches.
#292
#291 Done. Still adding more stuff that is output
#290 Done. Needs a unit test or an application test.
#287
#285
#277
#276 Done. Needs testing.
#253
#231
#218
#210 Done.
#174 Duplicate with #210
#154
#131
#116
#114
#109 Done.
#86
#65
Discussion
I need to profile and optimize the access of variable container. Due to frequent look-ups, it's essential to measure the performance difference between
std::map
,std::unordered_map
, andstd::vector
.Todo
Patterns::Selection
equations.cc
andvariableContainer
to prevent the calculated of quad point location. This could be a compile time flag or something. This is worth looking into because there is a decent amount of time spent calculating the quadrature point locations (~5%).type_enums