-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Hindi translation for UI strings on the About page #3526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kindly make sure to run the ESLint check before creating a PR. Also, several changes in your commit appear to be unnecessary. Please review your changes carefully before raising a pull request.
Thank you for the review, @yugalkaushik 🙏 ✅ Re‑ran npm run lint locally and fixed all lint errors. ✅ Removed unrelated or out‑of‑scope changes. ✅ Ran npm test: 25 test suites passed, 150 tests passed. ✅ Squashed commits for a clean history. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You don't need to commit the
package-lock.json
file, please exclude it from the PR. - You've updated the
bengali
translation instead ofhindi
, and in the process, removed several important text entries. - The changes made in
index.js
are unnecessary and have also removed some crucial comments.
Please take some time to go through the contribution and translation guidelines carefully. At the moment, this PR is unclear and doesn’t align with the issue's requirements.
f01c85d
to
ff0238c
Compare
Hi @yugalkaushik, The PR now contains only the intended Hindi translation updates as per the contribution guidelines. |
So what exactly are you trying to do here change the labels of About page or do hindi translation because I can't see any translation files and the package-lock.json file is still there. |
Thanks so much @yugalkaushik for the review and @Subham-KRLX for taking a look at this! The original issue attached here revolves around missing translations in the About page. I'm assuming this PR is trying to add in or update the Hindi translations for it? The file where this would happen is in In the proposed changes, we probably don't need to change the translation keys (i.e Since this PR isn't quite addressing what the original issue is looking for, I'm going to close this for now, but please feel free to reopen a new PR with the set of changes you would like to make! |
Fixes #3485
This pull request introduces a comprehensive Hindi translation for the user interface strings present on the "About" page of the p5.js Web Editor. The changes encompass:
Translation of all static text elements on the About page.
Updates to the hi.json locale file to include the new translations.
Ensuring consistency with existing translation guidelines and formatting.