-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Edits to clarify the "share" modal - fixes #3567 #3595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i18n(be): Update Settings and SubmitSaveAllSettings Keys
Update Ukrainian translation
…e-translation-error login-translation-bug
Hey @team-epk! Just wanted to check-in here! Let me know if you'd like any assistance with implementing any of the suggested changes! |
…social-links Adding social media links to Community Section of the ReadMe
Removed unnecessary file. Changed modal text to Title Case.
@raclim I just made the changes while you were typing, I think! Do I need to rebase the (Edited to add: now I see a commit note above this one, so maybe I did it at least sort of correctly?) |
Fix: completed cut-off sentence in contributor docs
…_yarn/multi-e981fcb12d Bump path-to-regexp and express
Thanks for the quick update on this! The new committed changes look great! Yes, you will have to update the I think either you can update
Yes, it's on its way there! The commit is being shown here since it references this pull request number! |
fix(i18n): Change Bengali locale code from 'be' to 'bn'
Removed unnecessary file. Changed modal text to Title Case.
@raclim I think I did it this time? If nothing else, I gave myself The Vapors™, but I think I also added the right branch with the right files, after a few frightening errors from git. |
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, fortunately I think it seems like it worked! 😁 Thanks so much again for picking this up! Feel free to raise or take on any other issues that you'd be interested in!
The merge-base changed after approval.
Fixes #3567
Changes:
Slight adjustments to the Share modal text:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123