Skip to content

Conversation

team-epk
Copy link
Contributor

Fixes #3567
Changes:
Slight adjustments to the Share modal text:

  • "Embed" becomes "Embed sketch"
    
  • "Fullscreen" becomes "Share sketch as view-only"
    
  • "Edit" becomes "Share sketch and allow editing"
    

I have verified that this pull request:

  • [ x ] has no linting errors (npm run lint)
  • [ x ] has no test errors (npm run test)
  • [ x ] is from a uniquely-named feature branch and is up to date with the develop branch.
  • [ x ] is descriptively named and links to an issue number, i.e. Fixes #123

@raclim
Copy link
Collaborator

raclim commented Aug 26, 2025

Hey @team-epk! Just wanted to check-in here! Let me know if you'd like any assistance with implementing any of the suggested changes!

raclim added 2 commits August 26, 2025 15:47
…social-links

Adding social media links to Community Section of the ReadMe
team-epk added a commit to team-epk/p5.js-web-editor that referenced this pull request Aug 26, 2025
Removed unnecessary file.
Changed modal text to Title Case.
@team-epk
Copy link
Contributor Author

team-epk commented Aug 26, 2025

@raclim I just made the changes while you were typing, I think! Do I need to rebase the share-modal branch with my local one I made the changes to? I'm following the "preparing a pull request" document, which I think is geared towards a new request, not editing an existing one.

(Edited to add: now I see a commit note above this one, so maybe I did it at least sort of correctly?)

@raclim
Copy link
Collaborator

raclim commented Aug 26, 2025

@raclim I just made the changes while you were typing, I think! Do I need to rebase the share-modal branch with my local one I made the changes to? I'm following the "preparing a pull request" document, which I think is geared towards a new request, not editing an existing one.

Thanks for the quick update on this! The new committed changes look great!

Yes, you will have to update the share-modal branch with the changes you just made! Looking into your repo, it seems like your latest changes are in the branch, share-modal-backup-aug-26-2025, while this PR is based on the branch share-modal.

I think either you can update share-modal with the changes you just made, or you can create a new PR based on the share-modal-backup-aug-26-2025 branch!

(Edited to add: now I see a commit note above this one, so maybe I did it at least sort of correctly?)

Yes, it's on its way there! The commit is being shown here since it references this pull request number!

@team-epk
Copy link
Contributor Author

@raclim I think I did it this time? If nothing else, I gave myself The Vapors™, but I think I also added the right branch with the right files, after a few frightening errors from git.

raclim
raclim previously approved these changes Aug 27, 2025
@team-epk team-epk dismissed raclim’s stale review August 27, 2025 15:36

The merge-base changed after approval.

raclim
raclim previously approved these changes Aug 27, 2025
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, fortunately I think it seems like it worked! 😁 Thanks so much again for picking this up! Feel free to raise or take on any other issues that you'd be interested in!

@team-epk team-epk dismissed raclim’s stale review August 27, 2025 15:42

The merge-base changed after approval.

@raclim raclim merged commit ed9a57c into processing:develop Aug 27, 2025
1 check passed
@team-epk team-epk deleted the share-modal branch August 27, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding "Mode" to the text in the Share Modal