Add error check for pixelDensity in mask() #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefterv
reviewed
May 18, 2025
Stefterv
approved these changes
May 28, 2025
|
Thanks @pnngocdoan for your contribution! ✨ @all-contributors please add @pnngocdoan for code |
|
I've put up a pull request to add @pnngocdoan! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #1065
Changes:
Add an error check for the mask() function in PImage.java to ensure both pixelWidth and pixelHeight of both imgs are matched.
Tests:
When pixel sizes don't match due to density difference, it will show an error line like below
When density doesn't match but underlying pixel size matches:
