Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lowest Python version for static type checking in CI #1270

Closed
wants to merge 2 commits into from
Closed

Use lowest Python version for static type checking in CI #1270

wants to merge 2 commits into from

Conversation

medihack
Copy link
Member

@medihack medihack commented Jan 5, 2025

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)

PR label(s):

@medihack medihack requested a review from a team as a code owner January 5, 2025 15:08
@github-actions github-actions bot added the PR type: miscellaneous 👾 Contains misc changes label Jan 5, 2025
ewjoachim
ewjoachim approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me publicly state that:

  • I suggested this approach
  • I hate yaml variable dark magic
  • I still think it's acceptable here.

Thank you!

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 5, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  procrastinate
  periodic.py
  psycopg_connector.py
  utils.py
  worker.py
  procrastinate/contrib/aiopg
  aiopg_connector.py
  procrastinate/sql
  __init__.py
Project Total  

This report was generated by python-coverage-comment-action

ewjoachim
ewjoachim approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great :)

@ewjoachim ewjoachim closed this Jan 5, 2025
@medihack medihack deleted the lowest-python-version-static-type-checking branch January 5, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim approved these changes

Assignees
No one assigned
Labels
PR type: miscellaneous 👾 Contains misc changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@medihack @ewjoachim