-
Notifications
You must be signed in to change notification settings - Fork 29
Bring in GenUI to build the settings page #424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Hello, @kevinaboos In this PR, I modified the |
Thanks! Sorry for the delay in my review, I was preoccupied with other work on OpenHarmony. The main problem that jumps out to me is that GenUI has a requirement for a specific version of Makepad. Unfortunately, Robrix itself also has a strict requirement to depend on a specific commit version of Makepad. Currently that version is in my
If GenUI has special requirements from Makepad, we cannot use it until the Makepad version that we need and the Makepad version that GenUI needs are the exact same. |
After discussing with Yifei, we found that So, if Robrix is using the Since a lot of GenUI's content is designed specifically for the rik branch, if too many changes are made in the |
introduce Genui into Robrix. Right now, only done the desktop version