Fixed bug in Processor class - it unexpectedly strips the final TextEdit in some cases #48
Conversation
…lement in case if consists only of one character.
| assertEquals( | ||
| Pattern( | ||
| TextElement("Hi "), | ||
| Placeable(expression = StringLiteral("")), |
There was a problem hiding this comment.
This expression here shouldn't pop up, and indicates a bug. I'm not sure that it's a bug in this patch, though.
There was a problem hiding this comment.
yes, it's another issue. I had to post-process a pattern to remove the redundant empty string literals in my app after this escaping.
There was a problem hiding this comment.
I've created the issue for this #49
|
Hi @RRagnar Thank you for the PR! I'm comfortable merging it but in order to not lose track of the bug that @Pike pointed out - can you please file a follow up issue and reference it from the comment by this test to indicate that this is an extraneous empty placeable and should be fixed? Then I think it'll be ready to merge. |
|
@zbraniecki Looks like RRagnar created the issue here: #49 |
| TextElement("!") | ||
| ) | ||
| ) | ||
|
|
There was a problem hiding this comment.
@gueroJeff @RRagnar Thank you! Can you please add an inline comment in the PR, like this:
| // The superfluous empty string literal is a bug. See #49. |
…lement in case if consists only of one character.